feat(bigquery observability): add version attribute to span tracing#12132
feat(bigquery observability): add version attribute to span tracing#12132
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the BigQuery client library's observability by integrating the client version into OpenTelemetry span traces. This addition provides crucial context for debugging and monitoring, allowing for easier identification of issues related to specific client versions. The change involves creating a dedicated version class and updating the telemetry tracer to utilize this version information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Version class to centralize the BigQuery client artifact version. This version is then integrated into the telemetry tracing mechanism, specifically by adding a GCP_CLIENT_VERSION attribute to OpenTelemetry spans. New and updated tests verify this telemetry attribute. A suggestion was made to reorder the Javadoc and annotations in the Version class to align with standard Java conventions.
java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Version.java
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
diegomarquezp
left a comment
There was a problem hiding this comment.
Looks good overall, just a minor comment
There was a problem hiding this comment.
This should be package private as per gax's approach.
This PR adds the gcp.client.version attribute to the span trace. It follows the general java guidance on retrieving version at runtime, by creating a Version.java file that stores the current version and is updated via release-please. See gapic version here.
Example trace with attribute.
There is a separate task to update release-please to handle updating this file.