-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix: correct typos and grammar in README #16535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mr-Documents
wants to merge
3
commits into
googleapis:main
Choose a base branch
from
Mr-Documents:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−17
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ Python Client for Google Cloud Storage | |||||
| |stable| |pypi| |versions| | ||||||
|
|
||||||
| `Google Cloud Storage`_ is a managed service for storing unstructured data. Cloud Storage | ||||||
| allows world-wide storage and retrieval of any amount of data at any time. You can use | ||||||
| allows worldwide storage and retrieval of any amount of data at any time. You can use | ||||||
| Cloud Storage for a range of scenarios including serving website content, storing data | ||||||
| for archival and disaster recovery, or distributing large data objects to users via direct download. | ||||||
|
|
||||||
|
|
@@ -43,13 +43,13 @@ Google APIs Client Libraries, in `Client Libraries Explained`_. | |||||
| Quick Start | ||||||
| ----------- | ||||||
|
|
||||||
| In order to use this library, you first need to go through the following steps. | ||||||
| To use this library, you first need to follow these steps. | ||||||
| A step-by-step guide may also be found in `Get Started with Client Libraries`_. | ||||||
|
|
||||||
| 1. `Select or create a Cloud Platform project.`_ | ||||||
| 2. `Enable billing for your project.`_ | ||||||
| 3. `Enable the Google Cloud Storage API.`_ | ||||||
| 4. `Setup Authentication.`_ | ||||||
| 4. `Set up Authentication.`_ | ||||||
|
|
||||||
| .. _Get Started with Client Libraries: https://cloud.google.com/storage/docs/reference/libraries#client-libraries-install-python | ||||||
| .. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||||||
|
|
@@ -145,15 +145,15 @@ Tracing With OpenTelemetry | |||||
| This is a PREVIEW FEATURE: Coverage and functionality are still in development and subject to change. | ||||||
|
|
||||||
| This library can be configured to use `OpenTelemetry`_ to generate traces on calls to Google Cloud Storage. | ||||||
| For information on the benefits and utility of tracing, read the `Cloud Trace Overview <https://cloud.google.com/trace/docs/overview>`_. | ||||||
| For information on the benefits and utility of tracing, read the `Cloud Trace Overview`_. | ||||||
|
|
||||||
| To enable OpenTelemetry tracing in the Cloud Storage client, first install OpenTelemetry: | ||||||
|
|
||||||
| .. code-block:: console | ||||||
|
|
||||||
| pip install google-cloud-storage[tracing] | ||||||
|
|
||||||
| Set the ``ENABLE_GCS_PYTHON_CLIENT_OTEL_TRACES`` environment variable to selectively opt-in tracing for the Cloud Storage client: | ||||||
| Set the ``ENABLE_GCS_PYTHON_CLIENT_OTEL_TRACES`` environment variable to opt in selectively to tracing for the Cloud Storage client: | ||||||
|
|
||||||
| .. code-block:: console | ||||||
|
|
||||||
|
|
@@ -199,8 +199,8 @@ For a list of libraries that can be instrumented, refer to the `OpenTelemetry Re | |||||
| Feedback Welcome | ||||||
| ~~~~~~~~~~~~~~~~ | ||||||
|
|
||||||
| If you experience that backwards compatibility for your application is broken | ||||||
| with this major version release, please let us know through the Github issues | ||||||
| If you experience any break in backwards compatibility for your application | ||||||
| with this major version release, please let us know through the GitHub issues | ||||||
| system. While some breaks of backwards compatibility may be unavoidable due to | ||||||
| new features in the major version release, we will do our best to minimize | ||||||
| them. Thank you. | ||||||
|
|
@@ -226,7 +226,7 @@ Some users may be using the original exception classes from the | |||||
| ``google-resumable-media`` library without explicitly installing that library. So | ||||||
| as not to break user applications following this pattern, | ||||||
| ``google-resumable-media`` is still in the list of dependencies in this package's | ||||||
| setup.py file. Applications which do not import directly from | ||||||
| setup.py file. Applications that do not import directly from | ||||||
| ``google-resumable-media`` can safely disregard this dependency. | ||||||
| This backwards compatibility feature **will be removed** in a future major | ||||||
| version update. Please migrate to using the ``google.cloud.storage.exceptions`` | ||||||
|
|
@@ -239,12 +239,11 @@ In Python Storage 3.0, uploads and downloads now have a default of "auto" where | |||||
| applicable. "Auto" will use crc32c checksums, except for unusual cases where the | ||||||
| fast (C extension) crc32c implementation is not available, in which case it will | ||||||
| use md5 instead. Before Python Storage 3.0, the default was md5 for most | ||||||
| downloads and None for most uploads. Note that ranged downloads ("start" or | ||||||
| "end" set) still do not support any checksumming, and some features in | ||||||
| downloads and none for most uploads. Note that ranged downloads ("start" or "end" set) still do not support any checksumming, and some features in | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the context of Python libraries,
Suggested change
|
||||||
| ``transfer_manager.py`` still support crc32c only. | ||||||
|
|
||||||
| Note: The method ``Blob.upload_from_file()`` requires a file in bytes mode, but | ||||||
| when checksum is set to None, as was the previous default, would not throw an | ||||||
| when checksum is set to None, as was the previous default, it would not throw an | ||||||
| error if passed a file in string mode under some circumstances. With the new | ||||||
| defaults, it will now raise a TypeError. Please use a file opened in bytes | ||||||
| reading mode as required. | ||||||
|
|
@@ -255,13 +254,12 @@ Miscellaneous | |||||
| - The ``BlobWriter`` class now attempts to terminate an ongoing resumable upload if | ||||||
| the writer exits with an exception. | ||||||
| - Retry behavior is now identical between media operations (uploads and | ||||||
| downloads) and other operations, and custom predicates are now supported for | ||||||
| media operations as well. | ||||||
| downloads) and other operations, and custom predicates are now supported | ||||||
| for media operations as well. | ||||||
| - ``Blob.download_as_filename()`` will now delete the empty file if it results in a | ||||||
| google.cloud.exceptions.NotFound exception (HTTP 404). | ||||||
| - Previously, object upload, metadata update, and delete methods had retries | ||||||
| disabled by default unless the generation or metageneration was specified in | ||||||
| the request. This has now changed so that retries are enabled by default. | ||||||
| disabled by default unless the generation or metageneration was specified in the request. This has now changed so that retries are enabled by default. | ||||||
|
|
||||||
|
|
||||||
| Next Steps | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to a reference link (
Cloud Trace Overview_) will likely break the link if the corresponding reference definition is not added to the document. Additionally, if the reference name contains spaces, it must be enclosed in backticks (e.g.,`Cloud Trace Overview`_) to be recognized as a single reference. It is recommended to revert to the inline link format to ensure the link remains functional.