feat(create-plugin): remove dependency on glob#2655
Open
theSuess wants to merge 2 commits into
Open
Conversation
Contributor
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged but will not trigger a new release. To trigger a new release add the |
|
|
|
|
theSuess
force-pushed
the
refactor-remove-dependency-on-glob-for-created-plugins/nlpmtqzktmrw
branch
from
4c29dd6 to
af8c2e0
Compare
theSuess
requested review from
hugohaggmark and
jackw
and removed request for
a team
theSuess
force-pushed
the
refactor-remove-dependency-on-glob-for-created-plugins/nlpmtqzktmrw
branch
from
af8c2e0 to
624c292
Compare
theSuess
force-pushed
the
refactor-remove-dependency-on-glob-for-created-plugins/nlpmtqzktmrw
branch
from
624c292 to
2a94489
Compare
theSuess
commented
May 29, 2026
| }, | ||
| { | ||
| name: '011-webpack-remove-glob-dependency', | ||
| version: '7.4.1', |
Collaborator
Author
There was a problem hiding this comment.
Not sure what to put here? Should this PR include the version bump or make a best guess?
theSuess
force-pushed
the
refactor-remove-dependency-on-glob-for-created-plugins/nlpmtqzktmrw
branch
from
2a94489 to
d09efa1
Compare
jackw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the spirit of reducing dependencies, this PR replaces the
globpackage with theglobfunction from the Node.js standard librarySpecial notes for your reviewer:
Not sure if we need a migration here. During testing, I realized that the webpack files in most plugins are not using the newest templates and are only partially updated by
006-webpack-nested-fix.ts.