examples: Reflow manualflowcontrol; check isReady() earlier#12726
Open
ejona86 wants to merge 1 commit intogrpc:masterfrom
Open
examples: Reflow manualflowcontrol; check isReady() earlier#12726ejona86 wants to merge 1 commit intogrpc:masterfrom
ejona86 wants to merge 1 commit intogrpc:masterfrom
Conversation
This change is mostly to flow the paragraph across multiple lines like all other text in this file. But I did also replace checking for isReady() before calling onNext() with checking before creating messages. If you already have the message created, it doesn't change much to go ahead and enqueue it, but don't go create another message immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is mostly to flow the paragraph across multiple lines like all other text in this file. But I did also replace checking for isReady() before calling onNext() with checking before creating messages. If you already have the message created, it doesn't change much to go ahead and enqueue it, but don't go create another message immediately.