bug/agentpoolworkspaces - Agent Pools using non-existent endpoints and failing to add allowed workspaces. (99)#110
Open
KshitijaChoudhari wants to merge 3 commits intonext-0.1.3from
Open
Conversation
isivaselvan
reviewed
Mar 20, 2026
| @@ -372,7 +410,11 @@ def delete(self, agent_pool_id: str) -> None: | |||
| def assign_to_workspaces( | |||
Collaborator
There was a problem hiding this comment.
As part of the path operation to assign and remove workspaces, api response wasn't captured instead it returned None
Collaborator
Author
There was a problem hiding this comment.
resolved
isivaselvan
reviewed
Mar 20, 2026
| } | ||
| self.t.request("PATCH", path, json_body=payload) | ||
|
|
||
| def remove_from_workspaces( |
Collaborator
Author
There was a problem hiding this comment.
resolved
…; update tests and example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has add/fix support for agent-pool workspaces and related examples/tests.
Restore and update agent-related models and examples to support agent pool workspaces.
Remove or refactor the deprecated agent_pools resource and replace usages with the new workflow.
Update unit tests and examples to reflect the API changes and ensure compatibility.
Files of interest:
agent_pool.py
agent.py
agent_pools.py
test_agent_pools.py
Testing plan
Run unit tests locally:
Install and activate the virtualenv if not active:
source .venv/bin/activate
Run the unit tests (focused and full):
pytest tests/units/test_agent_pools.py
pytest
3.Manually exercise examples against a TFE instance :
Update credentials as needed and run to validate end-to-end behavior.
External links
-->
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
If this change causes regressions:
Revert the branch by merging a revert PR or use git revert and open a follow-up PR.
Hotfixes can be applied to main if needed and backported to the release branch.
Changes to Security Controls
No intentional changes to access controls, encryption, or logging are included in this PR. If any of the example code requires secrets or tokens, ensure they are supplied via secure environment variables and not hard-coded.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.