Skip to content

Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 1.24.0.0#11630

Merged
mergify[bot] merged 1 commit intohaskell:masterfrom
zlonast:zlonast/old-mkVersion
Apr 15, 2026
Merged

Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 1.24.0.0#11630
mergify[bot] merged 1 commit intohaskell:masterfrom
zlonast:zlonast/old-mkVersion

Conversation

@zlonast
Copy link
Copy Markdown
Collaborator

@zlonast zlonast commented Mar 17, 2026

We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.

We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 1.24.0.0)

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@zlonast
Copy link
Copy Markdown
Collaborator Author

zlonast commented Mar 17, 2026

Should we drop compilers below 8.6? Or 8.8?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch 3 times, most recently from 1cd54e4 to 27e6671 Compare March 17, 2026 19:15
@ffaf1
Copy link
Copy Markdown
Collaborator

ffaf1 commented Mar 17, 2026

This does modify behaviour, does it not?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch 2 times, most recently from 9f262e4 to 2547133 Compare March 17, 2026 20:17
@zlonast
Copy link
Copy Markdown
Collaborator Author

zlonast commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

Comment thread Cabal/src/Distribution/Simple/Compiler.hs
@ffaf1
Copy link
Copy Markdown
Collaborator

ffaf1 commented Mar 18, 2026

@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior.

Makes sense!

Comment thread cabal-install/src/Distribution/Client/CmdRepl.hs Outdated
Comment thread Cabal/src/Distribution/Simple/Build/PackageInfoModule.hs Outdated
Comment thread Cabal/src/Distribution/Simple/Build/PathsModule.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHC/Build/Link.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHC/Build/Link.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHC/Build/Link.hs Outdated
@zlonast zlonast mentioned this pull request Mar 21, 2026
6 tasks
@zlonast zlonast requested review from ffaf1 and ulysses4ever March 21, 2026 19:33
Comment thread Cabal/src/Distribution/Simple/Build/PathsModule.hs Outdated
Comment thread cabal-dev-scripts/cabal-dev-scripts.cabal Outdated
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 314c399 to ca8e7bb Compare March 23, 2026 15:10
@zlonast zlonast changed the title Remove old mkVersion We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0) Mar 23, 2026
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 9e5e88e to f0bc384 Compare March 24, 2026 09:19
@zlonast zlonast mentioned this pull request Mar 24, 2026
6 tasks
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from fce4414 to 3b62aac Compare March 24, 2026 09:31
@zlonast
Copy link
Copy Markdown
Collaborator Author

zlonast commented Mar 24, 2026

Unknown package cabal-dev-scripts

🤔

Comment thread changelog.d/11630.md Outdated
Comment thread changelog.d/11630.md Outdated
Comment thread changelog.d/11630.md Outdated
@zlonast zlonast changed the title We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0) Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0 Mar 24, 2026
Copy link
Copy Markdown
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem there are still review comments to be addressed so it may need some more work in general I love the idea and removing code is good. Thank you!

@zlonast zlonast requested a review from ffaf1 March 26, 2026 19:54
@Bodigrim
Copy link
Copy Markdown
Collaborator

Bodigrim commented Apr 1, 2026

@zlonast could you please rebase?

@zlonast zlonast force-pushed the zlonast/old-mkVersion branch 2 times, most recently from 4e0b01a to 39ff388 Compare April 2, 2026 08:41
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 39ff388 to 5107892 Compare April 2, 2026 08:58
@zlonast zlonast requested a review from Bodigrim April 2, 2026 11:20
Comment thread cabal-install/src/Distribution/Client/ProjectPlanning.hs Outdated
Comment thread Cabal/src/Distribution/Simple/GHC/ImplInfo.hs
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from 5107892 to e2aa9e9 Compare April 7, 2026 10:05
@zlonast zlonast force-pushed the zlonast/old-mkVersion branch from e2aa9e9 to e2bd1f7 Compare April 12, 2026 11:57
@zlonast zlonast changed the title Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0 Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 1.24.0.0 Apr 12, 2026
Comment thread Cabal/src/Distribution/Simple/Register.hs
@zlonast zlonast added the merge me Tell Mergify Bot to merge label Apr 13, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Apr 13, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2026

Merge Queue Status

This pull request spent 1 hour 46 minutes 41 seconds in the queue, including 1 hour 36 minutes 25 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Apr 15, 2026
@mergify mergify bot merged commit debdc13 into haskell:master Apr 15, 2026
213 checks passed
@mergify mergify bot removed the queued label Apr 15, 2026
@zlonast zlonast deleted the zlonast/old-mkVersion branch April 15, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants