Cleanup 9.4 leftovers, fix couple -Wunused-packages and import warnings#4893
Merged
jhrcek merged 4 commits intohaskell:masterfrom Apr 12, 2026
Merged
Cleanup 9.4 leftovers, fix couple -Wunused-packages and import warnings#4893jhrcek merged 4 commits intohaskell:masterfrom
jhrcek merged 4 commits intohaskell:masterfrom
Conversation
jhrcek
force-pushed
the
jhrcek/cleanups-9.4
branch
from
fe00304 to
c77dda0
Compare
jhrcek
commented
Apr 11, 2026
|
|
||
| if impl(ghc >= 9.14) | ||
| allow-newer: | ||
| aeson:containers, |
Collaborator
Author
There was a problem hiding this comment.
Sorted alphabetically, removed some no-longer needed entries.
| .vscode | ||
| /test-logs/*.log | ||
|
|
||
| # stack 2.1 stack.yaml lock files |
Collaborator
Author
There was a problem hiding this comment.
Just deleting duplicated entries (they already exist few lines above this)
jhrcek
commented
Apr 11, 2026
| mFileContent <- getFileContents f | ||
| let fp = fromNormalizedFilePath f | ||
| modS <- liftIO $ runExceptT $ | ||
| getModSummaryFromImports session fp modTime (textToStringBuffer . Rope.toText <$> mFileContent) |
Collaborator
Author
There was a problem hiding this comment.
The modTime argument was used for ghc < 9.4, removing it allows for this simplification.
fendor
approved these changes
Apr 12, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you for the cleanup!
Collaborator
|
Merge when you are ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.