fix(helm/test-chart): allow to pull private oci image in test cluster

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

Author: neilime

actions/helm/test-chart/action.yml

@@ -153,27 +153,49 @@ runs:
       if: ${{ inputs.enable-install == 'true' }}
       uses: helm/kind-action@v1.12.0
 
+    - uses: docker/login-action@v3
+      with:
+        registry: ${{ inputs.oci-registry }}
+        username: ${{ inputs.oci-registry-username }}
+        password: ${{ inputs.oci-registry-password }}
+
+    - shell: bash
+      run: |
+        cat ~/.docker/config.json
+
+        HELM_SET="${{ inputs.helm-set }}"
+        # Extract image tag
+        IMAGE_TAG=$(echo "$HELM_SET" | grep -oP '(?<=tag=)[^,]*' | tr -d '[:space:]')
+
+        IMAGE="ghcr.io/cigales-cloud/landing-page/application:$IMAGE_TAG"
+
+        echo "IMAGE=$IMAGE"
+
+        # Try to pull the image from the OCI registry
+        docker pull "$IMAGE"
+
     - name: Install default OCI registry secrets
       id: oci-registry-secret
       if: ${{ inputs.enable-install == 'true' && inputs.oci-registry != '' && inputs.oci-registry-username != '' && inputs.oci-registry-password != '' }}
       shell: bash
       run: |
+        SECRET_NAME="regcred"
+        echo "oci-registry-secret=$SECRET_NAME" >> "$GITHUB_OUTPUT"
+
         # See https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
         NAMESPACE="${{ steps.prepare-ct-variables.outputs.namespace }}"
-        kubectl --context kind-chart-testing create namespace "$NAMESPACE"
+        kubectl create namespace "$NAMESPACE"
 
-        SECRET_NAME="regcred"
-        DOCKER_REGISTRY="${{ inputs.oci-registry }}"
-        DOCKER_USERNAME="${{ inputs.oci-registry-username }}"
-        DOCKER_PASSWORD="${{ inputs.oci-registry-password }}"
+        DOCKER_CONFIG_JSON_PATH=$(echo ~/.docker/config.json)
+        if [ ! -f "$DOCKER_CONFIG_JSON_PATH" ]; then
+          echo "::error ::Docker config.json file not found at $DOCKER_CONFIG_JSON_PATH"
+          exit 1
+        fi
 
-        kubectl --context kind-chart-testing create secret docker-registry "$SECRET_NAME" \
+        kubectl create secret generic "$SECRET_NAME" \
           --namespace="$NAMESPACE" \
-          --docker-server=$DOCKER_REGISTRY \
-          --docker-username=$DOCKER_USERNAME \
-          --docker-password=$DOCKER_PASSWORD
-
-        echo "oci-registry-secret=$SECRET_NAME" >> "$GITHUB_OUTPUT"
+          --from-file=".dockerconfigjson=$DOCKER_CONFIG_JSON_PATH" \
+          --type=kubernetes.io/dockerconfigjson
 
     - name: Run chart-testing (install)
       if: ${{ inputs.enable-install == 'true' }}
@@ -190,7 +212,7 @@ runs:
         OCI_REGISTRY_SECRET="${{ steps.oci-registry-secret.outputs.oci-registry-secret }}"
         if [ -n "$OCI_REGISTRY_SECRET" ]; then
           # Ensure secret exists
-          kubectl --context kind-chart-testing get secret "$OCI_REGISTRY_SECRET" --output=yaml --namespace=$NAMESPACE
+          kubectl get secret "$OCI_REGISTRY_SECRET" --output=yaml --namespace=$NAMESPACE
 
           HELM_SET="$HELM_SET
           imagePullSecrets[0].name=${OCI_REGISTRY_SECRET}"
@@ -203,7 +225,10 @@ runs:
             if [ -z "$line" ]; then
               continue
             fi
-            # Escape commas in the line
+            # Remove leading and trailing whitespace
+            line=$(echo "$line" | xargs) || true
+
+            # Escape commas in the line            
             line=$(echo "$line" | sed 's/,/\\,/g') || true
 
             if [ -n "$HELM_EXTRA_SET_ARGS" ]; then
@@ -216,8 +241,9 @@ runs:
 
         HELM_EXTRA_SET_ARGS="--set=${HELM_EXTRA_SET_ARGS}"
 
-        echo "::debug::ct install ${{ steps.prepare-ct-variables.outputs.args }} --helm-extra-set-args ${HELM_EXTRA_SET_ARGS}"
+        COMMAND="ct install ${{ steps.prepare-ct-variables.outputs.args }} --namespace $NAMESPACE --helm-extra-set-args='${HELM_EXTRA_SET_ARGS}'"
+
+        echo "::info ::$COMMAND"
 
-        ct install ${{ steps.prepare-ct-variables.outputs.args }} \
-          --namespace $NAMESPACE \
-          --helm-extra-set-args ${HELM_EXTRA_SET_ARGS}
+        # shellcheck disable=SC2086
+        eval $COMMAND