Skip to content

Commit c1b33e4

Browse files
committed
fix(helm/test-chart): pass helm-set properly
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
1 parent 53fb3f5 commit c1b33e4

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

actions/helm/test-chart/action.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -186,16 +186,16 @@ runs:
186186
NAMESPACE="${{ steps.prepare-ct-variables.outputs.namespace }}"
187187
kubectl create namespace "$NAMESPACE"
188188
189-
DOCKER_CONFIG_JSON_PATH=$(echo ~/.docker/config.json)
190-
if [ ! -f "$DOCKER_CONFIG_JSON_PATH" ]; then
191-
echo "::error ::Docker config.json file not found at $DOCKER_CONFIG_JSON_PATH"
192-
exit 1
193-
fi
189+
SECRET_NAME="regcred"
190+
DOCKER_REGISTRY="${{ inputs.oci-registry }}"
191+
DOCKER_USERNAME="${{ inputs.oci-registry-username }}"
192+
DOCKER_PASSWORD="${{ inputs.oci-registry-password }}"
194193
195-
kubectl create secret generic "$SECRET_NAME" \
194+
kubectl --context kind-chart-testing create secret docker-registry "$SECRET_NAME" \
196195
--namespace="$NAMESPACE" \
197-
--from-file=".dockerconfigjson=$DOCKER_CONFIG_JSON_PATH" \
198-
--type=kubernetes.io/dockerconfigjson
196+
--docker-server=$DOCKER_REGISTRY \
197+
--docker-username=$DOCKER_USERNAME \
198+
--docker-password=$DOCKER_PASSWORD
199199
200200
- name: Run chart-testing (install)
201201
if: ${{ inputs.enable-install == 'true' }}
@@ -242,8 +242,7 @@ runs:
242242
HELM_EXTRA_SET_ARGS="--set=${HELM_EXTRA_SET_ARGS}"
243243
244244
COMMAND="ct install ${{ steps.prepare-ct-variables.outputs.args }} --namespace $NAMESPACE --helm-extra-set-args='${HELM_EXTRA_SET_ARGS}'"
245-
246-
echo "::info ::$COMMAND"
245+
echo "::debug ::$COMMAND"
247246
248247
# shellcheck disable=SC2086
249248
eval $COMMAND

0 commit comments

Comments
 (0)