Add builder for updating multiple GHTeam properties.#2249
Add builder for updating multiple GHTeam properties.#2249rozza-sb wants to merge 3 commits intohub4j:mainfrom
Conversation
|
@bitwiseman re: using GHLabel as a base, I agree that this approach would be the more maintainable one going forward. However, we already have As it is this branch has a separate builder for updates, with only wiremocks missing. I'll be working on a commit that does the GHLabelBuilder-like pattern instead. |
|
I've taken a look at the GHLabel pattern, and I think this works quite well as both the create and update endpoints support the same properties. For GHTeam, there are differences between the create and the update endpoints:
Based on the difference between the create and update it does feel like these should be separate. My current plan is to get the existing change with wiremocks setup, partially due to the separate behaviour, and partially due to not having time before I head abroad to get this new setup in a satisfied state. If we're really against the existing approach, even as a stopgap, we could look at some migration strategy to support the new pattern with differing Creator and Updater requirements without breaking the existing |
Description
Currently GHTeam has some single methods on them to update description and privacy properties. There should be a mechanism for not only all properties being updatable (as supported per the GitHub API), but also for multiple properties to be updated atomically.
This change adds support for a new builder that allows for properties to be updated.
Fixes #2218.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: