Skip to content

Try fix 1ES runners#1353

Merged
jsturtevant merged 2 commits intohyperlight-dev:mainfrom
ludfjig:es_runners_jobid
Mar 31, 2026
Merged

Try fix 1ES runners#1353
jsturtevant merged 2 commits intohyperlight-dev:mainfrom
ludfjig:es_runners_jobid

Conversation

@ludfjig
Copy link
Copy Markdown
Contributor

@ludfjig ludfjig commented Mar 31, 2026

Runners are losing connection / dropped after just a couple of seconds or minutes of running. This mitigation is mentioned as a fix. Let's try it

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig requested a review from Copilot March 31, 2026 16:43
@ludfjig ludfjig added the kind/bugfix For PRs that fix bugs label Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to mitigate 1ES self-hosted runner disconnects by adding a unique JobId=... label to runs-on across multiple GitHub Actions workflows.

Changes:

  • Add a per-run unique JobId runner label (derived from github.run_id, github.run_number, and github.run_attempt) to multiple workflows using 1ES pools.
  • Update workflows using fromJson(format(...)) to include the extra label in the generated runner label list.
  • Apply the same mitigation to the copilot-setup-steps workflow for both AMD and Intel pools.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/dep_update_guest_locks.yml Adds JobId=... runner label to the update job to improve runner affinity/stability.
.github/workflows/dep_run_examples.yml Adds JobId=... into the dynamically formatted runs-on label list.
.github/workflows/dep_fuzzing.yml Adds JobId=... runner label to the fuzz job.
.github/workflows/dep_code_checks.yml Adds JobId=... runner label to both linux and windows checks jobs.
.github/workflows/dep_build_test.yml Adds JobId=... into the dynamically formatted runs-on label list for build/test.
.github/workflows/dep_build_guests.yml Adds JobId=... runner label to the guest build job.
.github/workflows/dep_benchmarks.yml Adds JobId=... into the dynamically formatted runs-on label list for benchmarks.
.github/workflows/copilot-setup-steps.yml Adds JobId=... to the conditional AMD/Intel runner selection expression.
.github/workflows/RustNightly.yml Adds JobId=... into the dynamically formatted runs-on label list for nightly runs.
.github/workflows/CreateRelease.yml Adds JobId=... runner label to release build and publish jobs.
.github/workflows/CargoPublish.yml Adds JobId=... runner label to the publish job.

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
@ludfjig ludfjig marked this pull request as ready for review March 31, 2026 19:19
This was referenced Mar 31, 2026
@jsturtevant jsturtevant merged commit ef15d0d into hyperlight-dev:main Mar 31, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants