Skip to content

Fix the issue where the default configuration parameters for the log …#11453

Closed
yangbryant wants to merge 2 commits intoiNavFlight:maintenance-9.xfrom
yangbryant:master
Closed

Fix the issue where the default configuration parameters for the log …#11453
yangbryant wants to merge 2 commits intoiNavFlight:maintenance-9.xfrom
yangbryant:master

Conversation

@yangbryant
Copy link
Copy Markdown

…do not take effect

@github-actions
Copy link
Copy Markdown

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@sensei-hacker sensei-hacker changed the base branch from master to maintenance-9.x March 24, 2026 13:59
@github-actions
Copy link
Copy Markdown

Test firmware build ready — commit cd464f0

Download firmware for PR #11453

228 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

@sensei-hacker
Copy link
Copy Markdown
Member

Thanks for the PR!
The log.c change looks good and fixes a real bug — PG_REGISTER was silently discarding the non-zero defaults in the reset template.

The serial.c change adds a TERMINALLOG_UART block but TERMINALLOG_UART isn't defined in any target .h file, so that code is currently unreachable, as far as I can see. Could you either add the definition or docuemtnation for how it should be used, or else split this into two PRs so the log.c fix can be merged now?"

@yangbryant
Copy link
Copy Markdown
Author

Thanks for the PR! The log.c change looks good and fixes a real bug — PG_REGISTER was silently discarding the non-zero defaults in the reset template.

The serial.c change adds a TERMINALLOG_UART block but TERMINALLOG_UART isn't defined in any target .h file, so that code is currently unreachable, as far as I can see. Could you either add the definition or docuemtnation for how it should be used, or else split this into two PRs so the log.c fix can be merged now?"

OK,i will split this into two PRs, i will submit one PR of the log.c fix first, and refine it with another PR later.

@yangbryant yangbryant closed this Apr 11, 2026
@yangbryant
Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants