api/pinterest: fallback images to the graphql api#1552
Open
zImPatrick wants to merge 1 commit intoimputnet:developfrom
Open
api/pinterest: fallback images to the graphql api#1552zImPatrick wants to merge 1 commit intoimputnet:developfrom
zImPatrick wants to merge 1 commit intoimputnet:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinterest sometimes just doesn't SSR the images into the HTML, so I implemented falling back to the GraphQL API in case no image was found. There's no support for videos in here right now, as they seem to be unaffected. I'd be down to add it if needed
I also tested an older query hash from January and that one also still works, so this should just keep working for a while