feat(text): add recipe and tokens#31170
Open
thetaPC wants to merge 14 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
brandyscarney
requested changes
May 28, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looking good! I am mostly requesting some additional screenshot tests and for us to either update the subtle colors or create a follow-up ticket.
brandyscarney
approved these changes
May 29, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good, thanks for making those changes! One comment about some screenshots that got updated but non-blocking.
Member
There was a problem hiding this comment.
Is this going to cause issues being unrelated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-textdoes not fragment styles based on themes. All 3 themes share one style. However, it's not configured to the Modular Ionic.What is the new behavior?
hueprop for selecting between vibrant and muted color variants. Defaults to"bold".IonTextRecipe/IonTextConfig/IonTextHuetypes.foregroundfor colors.Does this introduce a breaking change?
This PR introduces breaking changes to how
ion-textis styled.Migration Path:
Theme classes: Remove any instances that target the theme classes:
ion-text.md,ion-text.ios.Color prop: The color applied by the color prop now reads from
--ion-text-hue-{bold,subtle}-semantic-default-colorinstead of --ion-color-base directly. Consumers who were overriding the color via theme classes or by setting --ion-color-base on ion-text should switch to the new tokens.boldIonText.hue.bold.semantic.default.color--ion-text-hue-bold-semantic-default-colorsubtleIonText.hue.subtle.semantic.default.color--ion-text-hue-subtle-semantic-default-colorOther information
Previews