Open
Conversation
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
main
branch
2 times, most recently
from
64984b9 to
f71555b
Compare
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
from
fbec789 to
3708c30
Compare
felix-kaestner
force-pushed
the
main
branch
4 times, most recently
from
aed4596 to
8d57167
Compare
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
3 times, most recently
from
ef97c0e to
6789276
Compare
Contributor
There was a problem hiding this comment.
Can you please invoke make charts to also regenerate the Helm Chart incl. this CRD.
hardikdr
added
area/switch-automation
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
4 times, most recently
from
3af44d9 to
6b3940f
Compare
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
2 times, most recently
from
f8c1dcc to
cda5b26
Compare
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
from
0986b0b to
597e61c
Compare
In Cisco IOS XR the yang empty type is not implemented correctly for bundle-interfaces. Instead of returning "[null]" as defined in the RFC, "[\n null \n]" is. We simply work around of this.
For Bundle- and Bundlesubinterfaces creation fails, as the gnmi Update/Patch call, checks whether the object exists or not. We skip this check once if the gnmi call returns a NotFound error code.
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
from
597e61c to
274259e
Compare
sven-rosenzweig
force-pushed
the
feat/bundleiface
branch
from
274259e to
1f094cd
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.