explorer: show sample points over the heatmap in point mode#246
Open
rdhyee wants to merge 1 commit into
Open
Conversation
isamplesorg#242 made the heatmap mutually exclusive with both marker layers. That's right for cluster dots (aggregated — they contradict the density view), but individual sample points are exact per-sample locations that COMPLEMENT the heatmap (density = where it's busy, dots = the actual samples there). So at sample resolution (point mode) show the sample dots on top of the heatmap instead of hiding them; cluster dots stay hidden under the heatmap as before. One-line change in applyLayerVisibility() (the single marker-visibility control point). loadViewportSamples() already runs under heatmap in point mode, so the dots stay loaded and pan-fresh — this just unhides them. The heatmap is a Cesium imagery layer (globe surface), so sample primitives render on top of it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the heatmap is on and you're zoomed to sample resolution (point mode),
show the individual sample points on top of the heatmap instead of hiding them.
Why
#242 made the heatmap mutually exclusive with both marker layers. That's
correct for cluster dots — they're an aggregate/density view, so painting
them over the heatmap gives the dots-vs-hotspots contradiction flagged
2026-05-27. But individual sample points are exact per-sample locations that
complement the density overlay (heatmap = where it's dense, dots = the actual
samples there), so hiding them at sample zoom loses useful detail.
New rule in
applyLayerVisibility()(the single marker-visibility control point):Scope
One-line logic change (
viewer.samplePoints.show = mode === 'point') plus anexpanded rationale comment. No other paths needed:
loadViewportSamples()already runs under heatmap in point mode (moveEndhandler calls it unconditionally), so the dots are loaded and stay pan-fresh —
this just unhides them.
SingleTileImageryProvideronimageryLayers(globesurface), so sample primitives render on top of it.
quarto render explorer.qmdpasses. Built on top of #242.🤖 Generated with Claude Code