Conversation
|
😊 Welcome @mzacho! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
size/L
|
Hi @mzacho. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| use opentelemetry_sdk::logs::SdkLoggerProvider; | ||
|
|
||
| let mut builder = LogExporter::builder() | ||
| .with_tonic() |
There was a problem hiding this comment.
A very common use case is going to be wanting to connect to an in-cluster collector endpoint using mesh mtls. using the out-of-the-box client will not support this case.
There was a problem hiding this comment.
That makes sense. I don't know how to implement it though.
| // | ||
| // Note: This filtering will also drop logs from these components even when | ||
| // they are used outside of the OTLP Exporter. | ||
| let filter_otel = EnvFilter::new("trace") |
There was a problem hiding this comment.
generally I don't think that we want to just blindly send (even a subset) logs to otel. We probably only want access logs, and we want those to follow otel semantic conventions. This requires specialized calls specifically for otel. I wouldn't be surprised if it ends up not even using tracing at all.
There was a problem hiding this comment.
I would want the same logs that are currently logged to stdout to be available in OTEL. It seems weird to require that people run a file log exporter in order to get logs.
But I agree with the OTEL semantic conventions.
|
/ok-to-test |
istio-testing
added
ok-to-test
istio-testing
removed
the
needs-rebase
|
/retest |
6 participants
This PR adds as the ability to send tracing log Events to an OpenTelemetry collector via gRPC. When
OTLP_LOGGING=trueit uses opentelemetry-tracing-appender to add a OTEL tracing bridge as a layer to the current tracing subscriber registry. The current plain/json logging to stdout is not modified, so with this change ztunnel can either log:The collector endpoint can be configured with
OTEL_COLLECTOR_ENDPOINT.cc @ilrudie, you mentioned in #1625 you'd be curios to see how intrusive OpenTelemetry support is.