Add ENABLE_OUTBOUND_ORIG_SRC config for outbound source IP preservation#1749
Add ENABLE_OUTBOUND_ORIG_SRC config for outbound source IP preservation#1749bekerr1 wants to merge 1 commit intoistio:masterfrom
Conversation
|
😊 Welcome @bekerr1! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
|
Hi @bekerr1. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Stevenjin8
left a comment
There was a problem hiding this comment.
lgtm implementation wise, but want to give other folks a chance to take a look.
|
Thanks for the quick look Steven. Working on getting my CLA sorted also. |
|
/ok-to-test |
|
/retest |
For our multi-NIC pods, we use policy based routing (PBR) to influence the outbound interface. The routing looks something like the following
The intention of this change is to enable Ambient to honor the outbound source address it uses (obtained from the peer addr) in cases where it could receive redirected packets from multiple interfaces.
More on our specific use-case here for those interested:
istio/istio#58681
I wasn't sure if creating a separate env variable and making the distinction between ENABLE_ORIG_SRC, which is currently only used for inbound, was preferred over just re purposing the existing env. Open to suggestions here.