Add diff logic and parallel logger support for audit #642
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package audit | ||
|
Collaborator
There was a problem hiding this comment. maybe this should be at jfrog/jfrog-client-go#1297?
Contributor
Author
There was a problem hiding this comment. these are the options Move LogCollector to client-go - but it's really just a wrapper or we Keep it as is
Collaborator
There was a problem hiding this comment. Removing code from repo is always good :)
Contributor
Author
There was a problem hiding this comment. doen tell me if you like it now |
||
|
|
||
| import ( | ||
| "github.com/jfrog/jfrog-client-go/utils/log" | ||
| ) | ||
|
|
||
| // LogCollector captures logs for isolated parallel audit operations. | ||
| type LogCollector struct { | ||
| logger *log.BufferedLogger | ||
| } | ||
|
|
||
| func NewLogCollector(level log.LevelType) *LogCollector { | ||
| return &LogCollector{ | ||
| logger: log.NewBufferedLogger(level), | ||
| } | ||
| } | ||
|
|
||
| func (c *LogCollector) Logger() log.Log { | ||
| return c.logger | ||
| } | ||
|
|
||
| // ReplayTo outputs captured logs through the target logger (preserving colors). | ||
| func (c *LogCollector) ReplayTo(target log.Log) { | ||
| c.logger.ReplayTo(target) | ||
| } | ||
|
|
||
| func (c *LogCollector) HasLogs() bool { | ||
| return c.logger.Len() > 0 | ||
| } | ||
|
|
||
| func (c *LogCollector) Len() int { | ||
| return c.logger.Len() | ||
| } | ||
|
|
||
| func (c *LogCollector) String() string { | ||
| return c.logger.String() | ||
| } | ||
|
|
||
| func (c *LogCollector) Clear() { | ||
| c.logger.Clear() | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the collector is running on main routine so it will first record all the logs from main and it will collect the other after?