To support copy []any to []T#235
Open
happier233 wants to merge 1 commit intojinzhu:masterfrom
Open
Conversation
Author
|
@jinzhu Please help to review this PR. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for copying []any (i.e., []interface{}) to typed slices []T when the DeepCopy option is enabled, addressing issue #234 where copying []interface{} containing map[string]interface{} values to []map[string]string failed silently.
Changes:
- Modified the slice copy condition in
copier.goto also enter the element-by-element copy loop whenDeepCopyis enabled, not only when types are directly convertible. - Added tests for both
DeepCopy: true(successful copy) andDeepCopy: false(preserves existing no-op behavior) scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| copier.go | Adds opt.DeepCopy as an alternative condition to enter the slice element copy loop |
| copier_different_type_test.go | Adds TestCopyWithAnySlice with subtests for deep copy and non-deep copy of []interface{} → []map[string]string |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if err != nil { | ||
| t.Errorf("CopyStructWithOption() error = %v", err) | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #234