[Keras 3 OpenVINO Backend]: Clean up refactored CoreOpsCallsTests from excluded_concrete_tests.txt

[daehyun99]

• Fixes: [Keras 3 OpenVINO Backend]: Clean up refactored CoreOpsCallsTests from excluded_concrete_tests.txt #22423

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a foundational test structure for Keras core operations within the OpenVINO backend context. It introduces a dedicated test class, CoreOpsCallsTests, which will eventually contain comprehensive tests for key functional operations. This setup prepares the groundwork for future test development and ensures a structured approach to validating core functionalities.

Highlights

• New Test Class for Core Operations: Introduced CoreOpsCallsTests in keras/src/ops/core_test.py to house tests for core operations like fori_loop, map, switch, and unstack.
• Placeholder Test Methods: The newly added test methods within CoreOpsCallsTests currently raise NotImplementedError, indicating they are stubs for future implementation.
• Exclusion List Update: Removed CoreOpsCallsTests::test_unstack_basic_functionality from excluded_concrete_tests.txt, aligning with the creation of its placeholder in the new test class.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[daehyun99]

Some test case in excluded_concrete_tests.txt file already removed here. #22431

[gemini-code-assist]

Code Review

This pull request introduces a new test class CoreOpsCallsTests with placeholder test methods. My review focuses on two main points. First, a critical issue in excluded_concrete_tests.txt where a failing test is removed from the exclusion list, which would break the CI. I've suggested adding it back along with the other new failing tests. Second, I've pointed out a minor grammatical issue in the error messages of the new placeholder tests.

[daehyun99]

@themavik Yes, the test failures are intentional. The feature development has already been completed in #22431.

[hertschuh]

@themavik Yes, the test failures are intentional. The feature development has already been completed in #22431.

So is this PR still needed?

[daehyun99]

@hertschuh
Umm... I am not sure.

I followed the keras/src/backend/openvino/excluded_concrete_tests.txt path's commit log.
It seems that CoreOpsCallsTests class was removed in PR #21466
I can not found the any detailed comment in that PR. But, I think this PR isnt' need.

What do you think?

Thanks.

[hertschuh]

The CoreOpsCallsTests were refactored into classes with different names. The fact that they appeared in excluded_concrete_tests.txt was just an oversight.

So:

• revert keras/src/ops/core_test.py
• keep the one line change in excluded_concrete_tests.txt

[daehyun99]

@hertschuh
I am done.
Thank you for review.

Thanks.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.09%. Comparing base (4dcd8d2) to head (594d4a0).
⚠️ Report is 88 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #22449   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files         596      596           
  Lines       67623    67623           
  Branches    10535    10535           
=======================================
  Hits        56190    56190           
  Misses       8713     8713           
  Partials     2720     2720           

Flag	Coverage Δ
keras	82.92% <ø> (ø)
keras-jax	59.94% <ø> (ø)
keras-numpy	54.25% <ø> (ø)
keras-openvino	51.16% <ø> (ø)
keras-tensorflow	61.23% <ø> (ø)
keras-torch	60.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hertschuh]

Thanks!