fix: resolve chromedriver download by Chromium build line#191
Merged
sjmiller609 merged 4 commits intomainfrom Mar 26, 2026
Merged
fix: resolve chromedriver download by Chromium build line#191sjmiller609 merged 4 commits intomainfrom
sjmiller609 merged 4 commits intomainfrom
Conversation
rgarcia
approved these changes
Mar 26, 2026
AbdulRashidReshamwala
added a commit
to reclaimprotocol/popcorn-images
that referenced
this pull request
Mar 27, 2026
Resolved conflicts keeping both Reclaim-specific features and upstream improvements: - config.go: Kept TEE configuration (TEEKUrl, TEETUrl, AttestorUrl) - openapi.yaml: Kept /reclaim/prove endpoint and ReclaimProve* schemas - go.mod: Kept all Reclaim TEE dependencies and updated to latest versions - log.ts: Kept OpenTelemetry logging wrapper around base loggers - proxy.go: Adopted upstream's improved CDP reconnection logic with dialUpstreamWithRetry - Dockerfiles: Hybrid approach - auto-detect ChromeDriver version with override option Key upstream improvements integrated: - CDP proxy reconnection on Chromium restart (kernel#189, kernel#191) - Improved fonts support (kernel#165) - Better error handling in devtools proxy - Updated dependency versions All conflicts resolved, go.sum regenerated, oapi.go regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note
Medium Risk
Medium risk because it changes the browser-driver pairing in the runtime images and could introduce Chromium/ChromeDriver incompatibilities despite improving build reliability.
Overview
Updates both
images/chromium-headful/Dockerfileandimages/chromium-headless/image/Dockerfileto stop deriving ChromeDriver fromchromium --versionand instead download a separately pinnedCHROMEDRIVER_VERSION.This makes the Chrome for Testing download deterministic and avoids CI/build breakages when the exact Chromium patch version doesn’t exist upstream.
Written by Cursor Bugbot for commit b6ca9cb. This will update automatically on new commits. Configure here.