Conversation
…erClient Replace placeholder context.TODO() calls with context.Background() in the CapacityBufferClient methods. These are synchronous API calls that should use a root context rather than a placeholder TODO context. This improves code clarity and ensures proper context lifecycle management: - ListResourceQuotas - GetPodTemplate - UpdateCapacityBuffer - CreatePodTemplate - UpdatePodTemplate - GetScaleObject - GetPodFromCapacityBuffer Co-authored-by: Yaswanth Majety <63487431+YASWANTH28840@users.noreply.github.com>
Replace placeholder context.TODO() calls with context.Background() in: - balancer/main.go - balancer/pkg/client/informers/externalversions/balancer.x-k8s.io/v1alpha1/balancer.go - balancer/pkg/controller/controller.go - cluster-autoscaler/capacitybuffer/translators/pod_template_translator.go - cluster-autoscaler/capacitybuffer/translators/scalable_objects_translator.go These are synchronous API calls that should use a root context rather than a placeholder TODO context. This improves code clarity. Co-authored-by: Yaswanth Majety <63487431+YASWANTH28840@users.noreply.github.com>
Capitalize the first letter of comments in AliCloud SDK files to comply with Go code style guidelines. Comments should start with an uppercase letter or begin with the exported identifier they describe. Files: - cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/roa_signature_composer.go - cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/auth/rpc_signature_composer.go - cluster-autoscaler/cloudprovider/alicloud/alibaba-cloud-sdk-go/sdk/client.go Co-authored-by: Yaswanth Majety <63487431+YASWANTH28840@users.noreply.github.com>
Replace placeholder context.TODO() calls with context.Background() in the CherryServers cloud provider manager. These are synchronous API calls that should use a root context rather than a placeholder TODO context. Changes in cherry_manager_rest.go: - getCherryServer calls - listCherryServers calls - createNode calls - request calls - listCherryPlans calls Co-authored-by: Yaswanth Majety <63487431+YASWANTH28840@users.noreply.github.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/cleanup
|
Hi @YASWANTH28840. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YASWANTH28840 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/alicloud
2 participants
Replace placeholder context.TODO() calls with context.Background() in the
CherryServers cloud provider manager.
Changes:
These are synchronous API calls that should use a root context rather than
a placeholder TODO context. This improves code clarity and ensures proper
context lifecycle management.
/kind cleanup