Fix cluster-autoscaler VPA template with empty containerPolicy

[snigdhasambitak]

What type of PR is this?

/kind bug

What this PR does / why we need it

Fixes the cluster-autoscaler Helm chart VPA template (templates/vpa.yaml) which renders invalid YAML when vpa.containerPolicy is set to {} (the default value).

Which issue(s) this PR fixes

None found -- filing via this PR.

Bug

When vpa.enabled: true with the default containerPolicy: {}, the template on line 21:

    - containerName: {{ template "cluster-autoscaler.name" . }}
      {{- .Values.vpa.containerPolicy | toYaml | nindent 6 }}

Renders as:

    - containerName: aws-cluster-autoscaler
      {}

A flow mapping {} after an already-started block mapping key is a YAML syntax error, causing helm template to fail:

Error: YAML parse error on cluster-autoscaler/templates/vpa.yaml:
error converting YAML to JSON: yaml: line 22: did not find expected key

Fix

Wrap the containerPolicy rendering in a with block so an empty map produces no output instead of {}:

    - containerName: {{ template "cluster-autoscaler.name" . }}
      {{- with .Values.vpa.containerPolicy }}
      {{- toYaml . | nindent 6 }}
      {{- end }}

How to reproduce

helm template test cluster-autoscaler \
  --repo https://kubernetes.github.io/autoscaler \
  --version 9.56.0 \
  --set vpa.enabled=true \
  --set vpa.updateMode=Off

Verification

After the fix, both cases render valid YAML:

• containerPolicy: {} -- renders containerName only (no extra output)
• containerPolicy: {controlledResources: [cpu, memory]} -- renders correctly with resources listed

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: snigdhasambitak / name: Snigdha Sambit Aryakumar (bc58245, d6dfb0f)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snigdhasambitak
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• cluster-autoscaler/charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @snigdhasambitak!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @snigdhasambitak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.