Skip to content

Refactoring AutoscalerBuilder and Extracting NodeInfoComparator#9398

Open
GaetanoMar96 wants to merge 2 commits intokubernetes:masterfrom
GaetanoMar96:provreq
Open

Refactoring AutoscalerBuilder and Extracting NodeInfoComparator#9398
GaetanoMar96 wants to merge 2 commits intokubernetes:masterfrom
GaetanoMar96:provreq

Conversation

@GaetanoMar96
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR consolidates multiple architectural cleanups to make the AutoscalerBuilder more modular, testable with synctest, and provider-agnostic regarding node comparisons.

Key Changes:

  1. Moved NewAutoscaler to autoscaler builder package.
    Moved NewAutoscaler from core/autoscaler.go to builder/autoscaler.go and created autoscaler_factory.go.
    This breaks circular dependencies and makes the
    AutoscalerBuilder more self-contained.
  2. Extracting NodeInfoComparator to Individual Producers.
    Moved TemplateNodeInfoProvider and NodeInfoComparator setup logic from the multi-provider hub into individual cloud provider builders (e.g., aws.BuildAWS, gce.BuildGCE, azure.BuildAzure).
    Added generic override in NewCloudProvider for BalancingLabels when present to ensure user flags take precedence over provider defaults.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-area labels Mar 20, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GaetanoMar96
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from drmorr0 March 20, 2026 14:45
@k8s-ci-robot
Copy link
Contributor

Hi @GaetanoMar96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gce and removed do-not-merge/needs-area labels Mar 20, 2026
@GaetanoMar96 GaetanoMar96 changed the title Provreq Refactoring AutoscalerBuilder and Extracting NodeInfoComparator Mar 20, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@GaetanoMar96
Copy link
Contributor Author

/assign @towca @kawych @mtrqq

@GaetanoMar96 GaetanoMar96 marked this pull request as draft March 20, 2026 14:47
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@GaetanoMar96 GaetanoMar96 marked this pull request as ready for review March 20, 2026 14:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer March 20, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants