Skip to content

Feature: Add optional 'leases' etcd shard#18054

Open
apeabody wants to merge 4 commits intokubernetes:masterfrom
apeabody:ap/leases
Open

Feature: Add optional 'leases' etcd shard#18054
apeabody wants to merge 4 commits intokubernetes:masterfrom
apeabody:ap/leases

Conversation

@apeabody
Copy link
Contributor

@apeabody apeabody commented Mar 12, 2026

Adds support for configuring an optional leases etcd shard. This shard is specifically designed for megaclusters to isolate the massive volume of high-frequency write traffic generated by node heartbeats. By redirecting this traffic to a dedicated leases shard, it prevents the primary etcd database from being overwhelmed, ensuring overall control plane stability.

  • Allows 'leases' API validation
  • Maps well-known port assignments
  • Configures API Server overrides and nodeup DNS mapping
  • Updates Etcd Manager and TLS Configurations
  • Implements Node diagnostics, E2E integrations, and log overrides
  • Introduces mock test fixtures in cluster.go

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @apeabody. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from johngmyers March 12, 2026 02:44
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus March 12, 2026 02:44
@k8s-ci-robot k8s-ci-robot added area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/openstack Issues or PRs related to openstack provider labels Mar 12, 2026
- Allows 'leases' API validation
- Maps well-known port assignments
- Configures API Server overrides and nodeup DNS mapping
- Updates Etcd Manager and TLS Configurations
- Implements Node diagnostics, E2E integrations, and log overrides
- Introduces mock test fixtures in cluster.go
@hakman
Copy link
Member

hakman commented Mar 13, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2026
@hakman
Copy link
Member

hakman commented Mar 13, 2026

@apeabody Could you add some info in the description on why this is useful and who should use it?

Add documentation about the optional leases etcd shard for megaclusters, including an example configuration.
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2026
@apeabody
Copy link
Contributor Author

@apeabody Could you add some info in the description on why this is useful and who should use it?

Thanks @hakman - Also added to the create cluster documentation.

Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there value in giving this etcd cluster persistent remote storage like EBS volumes? @hakman I'm wondering if we could just give it a hostPath volume mount instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api area/documentation area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants