Skip to content

feat: Replace shipbot with gh-based script for promoting binaries#18095

Open
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:replace-shipbot
Open

feat: Replace shipbot with gh-based script for promoting binaries#18095
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:replace-shipbot

Conversation

@hakman
Copy link
Member

@hakman hakman commented Mar 18, 2026 •
edited
Loading

The new hack/promote-to-github.sh downloads binaries directly from artifacts.k8s.io and uploads them to the GitHub release using gh, ensuring byte-identical binaries between artifacts.k8s.io and GitHub.

/cc @ameukam @rifelpet @justinsb

% ./hack/promote-to-github.sh 1.32.4
Downloading binaries from https://artifacts.k8s.io/binaries/kops/1.32.4/ ...
  linux/arm64/protokube.sha256 -> protokube-linux-arm64.sha256
  linux/arm64/kops -> kops-linux-arm64
  linux/amd64/channels -> channels-linux-amd64
  linux/arm64/nodeup.sha256 -> nodeup-linux-arm64.sha256
  linux/amd64/kops.sha256 -> kops-linux-amd64.sha256
  linux/amd64/channels.sha256 -> channels-linux-amd64.sha256
  linux/amd64/protokube.sha256 -> protokube-linux-amd64.sha256
  linux/arm64/channels.sha256 -> channels-linux-arm64.sha256
  linux/arm64/channels -> channels-linux-arm64
  windows/amd64/kops.exe -> kops-windows-amd64
  linux/arm64/kops.sha256 -> kops-linux-arm64.sha256
  darwin/arm64/kops.sha256 -> kops-darwin-arm64.sha256
  linux/arm64/nodeup -> nodeup-linux-arm64
  linux/amd64/kops -> kops-linux-amd64
  darwin/amd64/kops -> kops-darwin-amd64
  linux/amd64/nodeup -> nodeup-linux-amd64
  darwin/amd64/kops.sha256 -> kops-darwin-amd64.sha256
  linux/amd64/protokube -> protokube-linux-amd64
  darwin/arm64/kops -> kops-darwin-arm64
  linux/arm64/protokube -> protokube-linux-arm64
  windows/amd64/kops.exe.sha256 -> kops-windows-amd64.sha256
  linux/amd64/nodeup.sha256 -> nodeup-linux-amd64.sha256
Uploading binaries to GitHub release v1.32.4 ...
Successfully uploaded 22 assets to v1.32.4

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman hakman force-pushed the replace-shipbot branch 2 times, most recently from 3bb242e to fc18473 Compare March 18, 2026 08:11
@hakman hakman changed the title Replace shipbot with gh-based script for promoting binaries feat: Replace shipbot with gh-based script for promoting binaries Mar 18, 2026
ameukam
ameukam reviewed Mar 18, 2026
View reviewed changes
hack/promote-to-github.sh Outdated

echo "Uploading binaries to GitHub release ${TAG} ..."

gh release upload "${TAG}" --repo "${REPO}" "${TMPDIR}"/*
Copy link
Member

@ameukam ameukam Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we upload but we don't verify ?

Copy link
Member Author

@hakman hakman Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added something, but should be already covered by set -o errexit

@hakman hakman force-pushed the replace-shipbot branch 2 times, most recently from a5fe72e to d1e9c20 Compare March 18, 2026 12:21
@hakman
Replace shipbot with gh-based script for promoting binaries
936b3f7 
The new hack/promote-to-github.sh downloads binaries directly from
artifacts.k8s.io and uploads them to the GitHub release using gh,
ensuring byte-identical binaries between artifacts.k8s.io and GitHub.

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman hakman marked this pull request as ready for review March 18, 2026 12:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@hakman
Copy link
Member Author

hakman commented Mar 18, 2026

/test pull-kops-e2e-k8s-gce-cilium

@ameukam
Copy link
Member

ameukam commented Mar 18, 2026

/lgtm
Farewell shipbot.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2026
@hakman
Copy link
Member Author

hakman commented Mar 18, 2026

/test pull-kops-e2e-k8s-gce-ipalias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

1 more reviewer

@ameukam ameukam ameukam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ameukam ameukam

Labels

area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @k8s-ci-robot @ameukam