fix: update launchdarkly-js-sdk-common to 5.8.1#341
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
May 26, 2026
kinyoklion
pushed a commit
that referenced
this pull request
May 26, 2026
🤖 I have created a release *beep* *boop* --- ## [3.9.1](3.9.1...3.9.1) (2026-05-26) ### Bug Fixes * update launchdarkly-js-sdk-common to 5.8.1 ([#341](#341)) ([41c99a9](41c99a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only changelog update with no runtime code changes in the diff. > > **Overview** > Adds a **3.9.1** changelog section dated 2026-05-26 for the automated release, documenting a bug fix that bumps **`launchdarkly-js-sdk-common`** to **5.8.1** ([#341](#341)). > > No application source changes appear in this diff—only release notes ahead of (or alongside) the version bump from Release Please. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6eef508. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
kinyoklion
added a commit
that referenced
this pull request
May 26, 2026
…#343) **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions N/A — config-only change, no application code modified. **Related issues** The release workflow failed because release-please created a duplicate 3.9.1 release PR (#342) when the tag already existed from the first 3.9.1 release (#333). **Describe the solution you've provided** Removes the `release-as: "3.9.1"` override from `release-please-config.json` that was added in #336. This override was intended as a one-time version force but was not cleaned up after the first 3.9.1 release shipped. When new commits (including #341) landed on main, release-please re-used the override and created a second 3.9.1 release PR (#342), which failed because the `3.9.1` tag already existed. Also removes the duplicate 3.9.1 CHANGELOG entry (with the broken `compare/3.9.1...3.9.1` link) that was added by #342. After this merges, release-please will correctly compute the next version based on conventional commits since the 3.9.1 tag. **Describe alternatives you've considered** N/A **Additional context** The `fix:` commit from #341 (update launchdarkly-js-sdk-common to 5.8.1) was not included in the published 3.9.1 npm package. Once this config fix merges, release-please should create a 3.9.2 release PR that includes that change. Link to Devin session: https://app.devin.ai/sessions/3fa824bb54c44fecb407c8aa43e3f193 Requested by: @kinyoklion <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Config and changelog-only; no runtime SDK code changes. > > **Overview** > Fixes a **release-please** misconfiguration that caused a second **3.9.1** release PR when commits landed after the real **3.9.1** tag already existed. > > The PR **removes** the leftover **`release-as: "3.9.1"`** entry from `release-please-config.json` (a one-time override that was never cleared after the first **3.9.1** shipped). It also **deletes** the erroneous duplicate **3.9.1** block from `CHANGELOG.md` (including the broken `compare/3.9.1...3.9.1` link) that came from that failed release PR. > > After merge, release-please should pick the next version from conventional commits since **3.9.1** (e.g. **3.9.2** for the unreleased `js-sdk-common` bump). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 28fe5fa. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
joker23
pushed a commit
that referenced
this pull request
May 26, 2026
🤖 I have created a release *beep* *boop* --- ## [3.9.2](3.9.1...3.9.2) (2026-05-26) ### Bug Fixes * update launchdarkly-js-sdk-common to 5.8.1 ([#341](#341)) ([41c99a9](41c99a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog-only release packaging with a patch dependency bump; no SDK source changes in the diff. > > **Overview** > **Release 3.9.2** bumps the published SDK version from `3.9.1` to `3.9.2` across `.release-please-manifest.json`, `package.json`, and `CHANGELOG.md`. > > The release notes document a **bug fix** that pulls in **`launchdarkly-js-sdk-common` 5.8.1** (via [#341](#341)); the diff shown here is the Release Please version/changelog sync rather than application source changes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ea3dc7b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A — routine dependency update.
Describe the solution you've provided
Update
launchdarkly-js-sdk-commonfrom5.8.0to5.8.1.Describe alternatives you've considered
N/A
Additional context
N/A
Link to Devin session: https://app.devin.ai/sessions/f3bb526db7cd4ea4a5a41df8a82eaa46
Requested by: @kinyoklion
Note
Low Risk
Low risk routine dependency patch update; behavior changes are limited to whatever upstream includes in
launchdarkly-js-sdk-common5.8.1.Overview
Updates the runtime dependency
launchdarkly-js-sdk-commonfrom5.8.0to5.8.1inpackage.json.Reviewed by Cursor Bugbot for commit abaf426. Bugbot is set up for automated code reviews on this repo. Configure here.