fix: goal manager bypasses event transformer#345
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
kinyoklion
approved these changes
May 29, 2026
joker23
pushed a commit
that referenced
this pull request
May 29, 2026
🤖 I have created a release *beep* *boop* --- ## [3.9.3](3.9.2...3.9.3) (2026-05-29) ### Bug Fixes * goal manager bypasses event transformer ([#345](#345)) ([a1ef119](a1ef119)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Release-metadata-only PR with no runtime code changes; the noted analytics URL fix is already merged separately. > > **Overview** > **Release 3.9.3** — automated version bump only: `package.json` and `.release-please-manifest.json` move from **3.9.2** to **3.9.3**, and **CHANGELOG.md** gains the **3.9.3** section dated 2026-05-29. > > The changelog entry records the shipped fix from [#345](#345): **goal manager** events (pageview / click_pageview) now respect **`eventUrlTransformer`**, which had previously been skipped for those paths while `track()` already applied it. **No SDK source files appear in this diff** — implementation landed in an earlier commit ([a1ef119](a1ef119)). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d7fa5a3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small behavioral fix aligning goal URLs with other events; covered by new tests with no auth or data-model changes.
Overview
Goal conversion events (
pageview,click_pageview, etc.) now take theirurlfromplatform.getCurrentUrl()instead ofwindow.location.href, so the optionaleventUrlTransformerapplies to goal traffic the same way it already does fortrack()and other SDK events.GoalManageraccepts aplatformargument;initializepasses the existingbrowserPlatforminstance. New unit tests cover transformed and untransformed goal event URLs.Reviewed by Cursor Bugbot for commit aba6fd2. Bugbot is set up for automated code reviews on this repo. Configure here.