Skip to content

[Merged by Bors] - feat(CategoryTheory/Sites): Over.post F preserves covers if F does#37775

Closed
chrisflav wants to merge 5 commits intoleanprover-community:masterfrom
chrisflav:over-post-sites
Closed

[Merged by Bors] - feat(CategoryTheory/Sites): Over.post F preserves covers if F does#37775
chrisflav wants to merge 5 commits intoleanprover-community:masterfrom
chrisflav:over-post-sites

Conversation

@chrisflav
Copy link
Copy Markdown
Member

We also show the lifting covers variant. Notably, we don't show that Over.post F is continuous if F is. This would follow for example from showing that sheaves on Over X are sheaves on C over yoneda.obj X, which we don't have yet.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

PR summary 16cc871c27

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.CategoryTheory.CoverPreserving.overPost
+ instance {D : Type*} [Category* D] (K : GrothendieckTopology D)
+ overEquiv_functorPullback_post
+ overEquiv_functorPushforward_post
++ post_forget_eq_forget_comp

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
6458 2 backward.isDefEq.respectTransparency

Current commit 07e5fa17ad
Reference commit 16cc871c27

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/CategoryTheory/Comma/Over/Basic.lean Outdated
Comment thread Mathlib/CategoryTheory/Comma/Over/Basic.lean Outdated
@joelriou
Copy link
Copy Markdown
Contributor

joelriou commented Apr 8, 2026

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 8, 2026

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 8, 2026
@chrisflav
Copy link
Copy Markdown
Member Author

Thanks for the review!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 13, 2026
#37775)

We also show the lifting covers variant. Notably, we don't show that `Over.post F` is continuous if `F` is. This would follow for example from showing that sheaves on `Over X` are sheaves on `C` over `yoneda.obj X`, which we don't have yet.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 13, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Sites): Over.post F preserves covers if F does [Merged by Bors] - feat(CategoryTheory/Sites): Over.post F preserves covers if F does Apr 13, 2026
@mathlib-bors mathlib-bors bot closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants