Draft
Conversation
Move CancelToken from Init.System.IO to its own file Init.System.CancelToken, backed by IO.Promise Unit instead of IO.Ref Bool. This adds a CancelToken.task method returning a Task Unit that completes when cancelled, enabling non-polling cancellation propagation via IO.mapTask. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nomeata
added
the
merge-ci
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This PR updates `check_interrupted()` in the C++ runtime to check the Promise-based `CancelToken` directly via `lean_io_get_task_state_core`, rather than calling the Lean-exported `lean_io_cancel_token_is_set`. The old approach failed during stage2 build because the stage0-compiled export assumed the IORef-based representation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update `delabConst.lean` and `printStructure.lean` to reflect that `IO.CancelToken` now wraps `IO.Promise Unit` instead of `IO.Ref Bool`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves CancelToken from Init.System.IO to its own file Init.System.CancelToken, backed by IO.Promise Unit instead of IO.Ref Bool. This adds a CancelToken.task method returning a Task Unit that completes when cancelled, enabling non-polling cancellation propagation via IO.mapTask.
(An experiment so far.)