Update ESoCC strings after UX writing review#5819
Update ESoCC strings after UX writing review#5819marcellamaki wants to merge 2 commits intolearningequality:unstablefrom
Conversation
| tooltip: 'Review flagged submission', | ||
| text: 'Needs changes', | ||
| tooltip: 'Submission requires changes before approval', | ||
| color: theme.red.v_100, |
There was a problem hiding this comment.
these are admin-only so not translated, but I updated the langage here for consistency
| const infoSection = wrapper.find('.info-section'); | ||
| expect(infoSection.exists()).toBe(true); | ||
| expect(infoSection.text()).toContain(flaggedPrimaryInfo$()); | ||
| expect(infoSection.text()).toContain(needsChangesPrimaryInfo$()); |
There was a problem hiding this comment.
renamed the string as well for consistency
| if (!latestSubmissionIsFinished.value) return undefined; | ||
|
|
||
| switch (latestSubmissionStatus.value) { | ||
| case CommunityLibraryStatus.PENDING: |
There was a problem hiding this comment.
removed as redundant
| :buttonValue="PublishModes.LIVE" | ||
| :currentValue="mode" | ||
| :description="modeLiveDescription$()" | ||
| :description="publishChannelDescription$()" |
| }" | ||
| > | ||
| {{ incompleteResourcesDescription2$() }} | ||
| </div> |
There was a problem hiding this comment.
removed as unnecessary
| }, | ||
| versionNotesLabel: { | ||
| message: "Describe what's new in this channel version", | ||
| message: "Describe what's included in this channel version", |
There was a problem hiding this comment.
this was per request from Laura
| languageRequiredMessage: { | ||
| message: 'Language is required', | ||
| context: 'Error message when language selection is required but not provided', | ||
| }, |
There was a problem hiding this comment.
reusing "This field is required" common string
marcellamaki
force-pushed
the
update-esocc-strings
branch
from
33d17ac to
5450358
Compare
| needsChangesPrimaryInfo: { | ||
| message: | ||
| 'A previous version was flagged for review. Ensure you have fixed all highlighted issues before submitting.', | ||
| 'Your previously submitted version needs changes. Make sure you have addressed all feedback before resubmitting.', |
There was a problem hiding this comment.
note: i slightly revised the wording here because I think "highlighted issues" might be interpreted too literally, and not everything will always be indicated via the UI
There was a problem hiding this comment.
I would only suggest to swap feedback with comments.
| alreadySubmittedWarningDescription: { | ||
| message: | ||
| 'Please wait for review or make changes and publish a new version before submitting again.', | ||
| 'Please wait for the channel to be reviewed. You will see a notification in your Studio account after the review is complete.', |
There was a problem hiding this comment.
note - it will not be an email, per richard :)
| incompatibleLicensesDescription: { | ||
| message: | ||
| '"{licenseNames}" - this channel cannot be distributed via Kolibri. Please fix licensing before submitting a new version.', | ||
| '"{licenseNames}" - this channel cannot be distributed via Kolibri. If you cannot change the license, remove all resources with "{licenseNames}" before submitting again.', |
There was a problem hiding this comment.
I realized belatedly that this also appears as a warning for "all rights reserved" as well before submission, so I repeated the {licenseNames} so it could be flexible.
marcellamaki
force-pushed
the
update-esocc-strings
branch
2 times, most recently
from
3d91548 to
f8a260d
Compare
marcellamaki
force-pushed
the
update-esocc-strings
branch
from
f8a260d to
13335de
Compare
| publishDraftDescription: { | ||
| message: | ||
| 'Your channel will be saved as a draft, allowing you to review or conduct quality checks without altering the published version on Kolibri public library.', | ||
| 'Your channel will be saved as a draft, allowing you to review or conduct quality checks without altering the version Kolibri users can access. To see your channel in Kolibri, import using the draft channel token.', |
There was a problem hiding this comment.
Suggestion:
Your channel will be saved as a draft, allowing you to review and do quality checks on the draft, without altering the current version available for Kolibri users. To see this draft channel in Kolibri, import using the draft channel token.
2 participants
Summary
…
References
…
Reviewer guidance
…
AI usage