You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pintsized I'll add tests, no problem.
We use your library as a proxy server, in which case we want to send any HTTP request the customer sends - even the initial HTTP(S) request to a WebSocket server.
In our code we then check if the response contains the Upgrade header and the HTTP 101 status. If it does - we take the inner socket and work directly with it. But we still use your library as a generic way to send the first HTTP request :)
If it makes sense - I'll write some tests and commit.
@pintsized added tests, also added support for 'ws' and 'wss' scheme in parse_uri (which I think is important because users would probably parse_uri() before they connect())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.