Use is_effectively_ghosted() in PetscVector#4430
Merged
roystgnr merged 2 commits intolibMesh:develfrom Apr 7, 2026
Merged
Conversation
I only need this for PetscVector, for several layers of reasons at this point, but I suppose it is the sort of thing that could be useful in general and from user code, so we'll make it public and leave it in the base class.
Now that we're storing general metadata for a constructed PetscVector in type() but sometimes doing something different with our specific Vec object for efficiency, we need to have our Vec operations match the Vec, not the metadata. This fixes a MOOSE regression for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we're storing general metadata for a constructed PetscVector in type() but sometimes doing something different with our specific Vec object for efficiency, we need to have our Vec operations match the Vec, not the metadata.
This fixes a MOOSE regression for me, thanks to @loganharbour for pointing out the CI failure.