TPT-4256: Implemented changes for SLADE and CLEO projects#910
Merged
ezilber-akamai merged 3 commits intolinode:proj/slade-cleofrom Apr 7, 2026
Merged
Conversation
ezilber-akamai
added
breaking-change
ezilber-akamai
requested review from
ckulinsk and
lgarber-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linode instance/disk create request models to support new SLADE/CLEO-related fields and to allow omitting root_pass by switching it to a pointer type.
Changes:
- Add
kernelandboot_sizetoInstanceCreateOptions. - Change
root_passfromstringto*stringfor Instance create/rebuild and Disk create options (breaking change). - Update unit/integration tests to use
linodego.Pointer(...)for the new pointer-basedRootPassfields.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
instances.go |
Makes RootPass optional via *string; adds Kernel and BootSize to instance create options. |
instance_disks.go |
Makes disk-create RootPass optional via *string. |
test/unit/instance_test.go |
Updates unit tests for instance create/rebuild to use pointer-based RootPass; adds coverage for new fields in the options struct. |
test/unit/instance_disks_test.go |
Updates unit test for disk create to use pointer-based RootPass. |
test/integration/instances_test.go |
Updates integration tests to use pointer-based RootPass in instance/disk workflows. |
test/integration/instance_reserved_ips_test.go |
Updates integration tests to use pointer-based RootPass when creating instances. |
test/integration/instance_interfaces_test.go |
Updates integration helper to use pointer-based RootPass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
force-pushed
the
TPT-4256-slade-cleo
branch
from
f0adc5d to
b95d315
Compare
ezilber-akamai
removed
the
breaking-change
ezilber-akamai
changed the title
ezilber-akamai
force-pushed
the
TPT-4256-slade-cleo
branch
from
6847cf5 to
86c5a66
Compare
zliang-akamai
approved these changes
Apr 3, 2026
Member
zliang-akamai
left a comment
zliang-akamai
left a comment
There was a problem hiding this comment.
Looks good to me, nice work!
lgarber-akamai
approved these changes
Apr 7, 2026
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added new
kernelandboot_sizefields to Linode Create options. Also added a notice that one ofroot_passauthorized_users, orauthorized_keysis required whenimageis provided rather than just requiringroot_pass.✔️ How to Test
make test-unit