upcoming: [UIE-10432] - Implement drawer to reserve an IP address#13541
Open
grevanak-akamai wants to merge 3 commits intolinode:developfrom
Open
upcoming: [UIE-10432] - Implement drawer to reserve an IP address#13541grevanak-akamai wants to merge 3 commits intolinode:developfrom
grevanak-akamai wants to merge 3 commits intolinode:developfrom
Conversation
645da3c to
c27bd14
Compare
c27bd14 to
aae33c8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a reusable “Reserve IP Address” drawer (create/edit/reserve modes) and wires it into the Reserved IPs landing empty state, along with supporting query/mocks and minor UI enhancements.
Changes:
- Added
ReserveIPDrawercomponent (with tests) and integrated it into the Reserved IPs landing empty state. - Added a reserved IP types query (
useReservedIPTypesQuery) and updated API client to use the beta endpoint for reserved IP types. - Extended MSW CRUD mocks to support reserving an IP and fetching reserved IP types; updated
TagsInputto support an optional label.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/queries/src/networking/networking.ts | Adds a query key + hook for fetching reserved IP pricing types. |
| packages/manager/src/mocks/presets/crud/networking.ts | Registers new networking CRUD handlers for reserved IPs. |
| packages/manager/src/mocks/presets/crud/handlers/networking.ts | Adds MSW handlers for reserving an IP and fetching reserved IP types. |
| packages/manager/src/mocks/presets/baseline/crud.ts | Includes networking CRUD handlers in the baseline CRUD preset. |
| packages/manager/src/features/ReservedIps/constants.ts | Adds drawer description text and docs link constants. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLandingEmptyState.tsx | Hooks up the “Reserve an IP Address” CTA to open the drawer. |
| packages/manager/src/features/ReservedIps/ReserveIPDrawer.tsx | New drawer component implementing create/edit/reserve behavior, pricing display, and submission. |
| packages/manager/src/features/ReservedIps/ReserveIPDrawer.test.tsx | Adds unit tests covering loading state, create/edit/reserve modes, cancel, and pricing display. |
| packages/manager/src/factories/types.ts | Adds a reservedIPsTypeFactory for mock reserved IP pricing types. |
| packages/manager/src/components/TagsInput/TagsInput.tsx | Adds optional prop and forwards it to the underlying text field. |
| packages/manager/.changeset/pr-13541-upcoming-features-1774844980662.md | Adds an Upcoming Features changeset entry for the drawer. |
| packages/api-v4/src/networking/types.ts | Aligns IPAddress.assigned_entity with the shared Entity type. |
| packages/api-v4/src/networking/networking.ts | Switches getReservedIPsTypes to the beta API root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aae33c8 to
3c52d60
Compare
3c52d60 to
9287df8
Compare
9287df8 to
92fd360
Compare
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
tanushree-akamai
approved these changes
Apr 2, 2026
Contributor
tanushree-akamai
left a comment
There was a problem hiding this comment.
Thanks @grevanak-akamai!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
As part of this PR, implemented common drawer to reserve an IP address that can be reused in different usecases such as reserving a random IP address in a region, editing an IP address or reserving existing IP address. Integrated this drawer in reserved IP addresses landing page.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Apr 2026
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅