[upcoming] UIE-9410: Implement the Create Share Group page by fabrice-akamai · Pull Request #13550 · linode/manager

fabrice-akamai · 2026-03-31T16:27:29Z

Description 📝

This PR implements the 'Create Share Group' page along with the supporting functions for querying, routing, and submitting the form. With these changes, users can now create share groups from the UI instead of relying on API requests alone. This is the first of 3 PRs for this ticket; future PRs will implement the Images and Selected images sections.

Changes 🔄

List any change(s) relevant to the reviewer.

Added ShareGroupsCreate page with landing header and form
Added ShareGroupsCreate form
Added ShareGroupsCreate query mutation in sharegroups.ts
Added new route in routes/images/index.ts
Added unit tests for the ShareGroupsCreate form

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

TBD

Preview 📷

Screen.Recording.2026-03-31.at.12.55.58.PM.mov

How to test 🧪

Prerequisites

In an environment with the Private Image Sharing feature flag enabled,

Navigate to Images -> Share Groups tab
Click the 'Create Share Group' button on the landing page

Verification steps

(How to verify changes)

Fill the label and optionally the description field
Click Create Share Group
Verify that your share group was successfully created and appears in the table
Test edge cases such as submitting an empty form, missing label, spaces and special characters in label, exceeding character limit in label field, etc. Make sure the form displays the correct error message and handles errors gracefully
Verify that the breadcrumb and docs links work properly

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…nto develop

packages/manager/.changeset/pr-13550-upcoming-features-1774974481770.md

packages/queries/src/images/sharegroups.ts

dwiley-akamai · 2026-03-31T18:32:53Z

...ger/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreate.tsx

+          <Controller
+            control={control}
+            name="description"
+            render={({ field, fieldState }) => (
+              <TextField
+                errorText={fieldState.error?.message}
+                label="Description"
+                multiline
+                noMarginTop
+                {...field}
+                onChange={(e) =>
+                  field.onChange(
+                    e.target.value === '' ? undefined : e.target.value
+                  )
+                }
+                rows={1}
+                value={field.value ?? ''}
+              />
+            )}
+          />


Let's check with the API team on implementing a maximum number of characters for the description field

Good point, I'll reach out to them about this.

...ger/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreate.tsx

…481770.md Co-authored-by: Dajahi Wiley <[email protected]>

…/fabrice-akamai/manager into UIE-9410-create-share-group-page

abailly-akamai

Nice - PR looks good from a code/UI perspective 👍

abailly-akamai · 2026-04-01T08:08:47Z

...eatures/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreateContainer.tsx

@@ -0,0 +1,24 @@
+import Grid from '@mui/material/Grid';


Let's no do straight imports from @mui

Is there an alternative you suggest @abailly-akamai? We do this throughout the codebase and I don't believe we have a Grid in the ui package

🤕 My bad old habit when I see a MUI import. It's one of the very few component we haven't abstracted. Carry on!

Haha, no worries. Thanks for clarifying this @dwiley-akamai @abailly-akamai!

dwiley-akamai

Verification steps ✅
Code review ✅

dwiley-akamai · 2026-04-01T18:02:19Z

...eatures/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreateContainer.tsx

@@ -0,0 +1,24 @@
+import Grid from '@mui/material/Grid';


Is there an alternative you suggest @abailly-akamai? We do this throughout the codebase and I don't believe we have a Grid in the ui package

fabrice-akamai · 2026-04-01T23:02:17Z

I made a few additional changes to the ShareGroupsTable to improve the display of the Group and Description fields when the text is too large:

Removed line wrap so that the text overflow gets truncated with ellipses
Added a tooltip to show the full text
Made the description column wider

Same width (current)	Wider description column (new)

@tzmiivsk-akamai any thoughts on expanding the description column and adding a tooltip to the group cells?

cc: @dwiley-akamai @abailly-akamai

linode-gh-bot · 2026-04-01T23:40:19Z

Cloud Manager UI test results

🔺 3 failing tests on test run #7 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`3 Failing`	`885 Passing`	`11 Skipped`	`43m 31s`

Details

Failing Tests
	Spec	Test
❌	`account-switching.spec.ts`	Cloud Manager Cypress Tests→Parent/Child account switching→From Parent to Child » can search child accounts
❌	`object-storage.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
❌	`object-storage.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage end-to-end tests » can update bucket access

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

tzmiivsk-akamai · 2026-04-02T11:15:44Z

I made a few additional changes to the ShareGroupsTable to improve the display of the Group and Description fields when the text is too large:

Removed line wrap so that the text overflow gets truncated with ellipses

Added a tooltip to show the full text

Made the description column wider

@tzmiivsk-akamai any thoughts on expanding the description column and adding a tooltip to the group cells?

Looking good! A couple of small adjustments:
Let's show tooltips only when the description is truncated to avoid visual noise.
Can we narrow down 'Members'/'Images' columns and expand 'Group' instead?
Paddings (left of 'Group' and right of 'Action Menu') look a bit wider than the designs.

Could you please double-check these? Thanks!

fabrice-akamai added 9 commits September 26, 2025 10:40

Added missing padding around the Managed dashboard card

8680aae

changed spacing to spacingFunction

d53e3f6

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

ef5485f

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

2a8188d

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

2db02f3

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

a8323a1

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

77ec16e

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

4a803c8

…nto develop

Implement basic sharegroup create form

408d904

github-project-automation bot added this to Cloud Manager Mar 31, 2026

github-project-automation bot moved this to Review in Cloud Manager Mar 31, 2026

fabrice-akamai added 2 commits March 31, 2026 12:28

Added changeset: Implement the basic share group create page

1befb73

update unit test

2c3f4dc

fabrice-akamai requested review from abailly-akamai, dwiley-akamai and pmakode-akamai March 31, 2026 17:04

Merge branch 'develop' into UIE-9410-create-share-group-page

66a034c

fabrice-akamai marked this pull request as ready for review March 31, 2026 17:04

fabrice-akamai requested a review from a team as a code owner March 31, 2026 17:04

dwiley-akamai assigned fabrice-akamai Mar 31, 2026

dwiley-akamai added the Private Image Sharing Related to Private Image Sharing feature label Mar 31, 2026

dwiley-akamai reviewed Mar 31, 2026

View reviewed changes

fabrice-akamai and others added 3 commits March 31, 2026 14:41

Update packages/manager/.changeset/pr-13550-upcoming-features-1774974…

007e94d

…481770.md Co-authored-by: Dajahi Wiley <[email protected]>

Update the createShareGroup query

2dbdb37

Merge branch 'UIE-9410-create-share-group-page' of https://github.com…

664d8c3

…/fabrice-akamai/manager into UIE-9410-create-share-group-page

abailly-akamai approved these changes Apr 1, 2026

View reviewed changes

dwiley-akamai approved these changes Apr 1, 2026

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Apr 1, 2026

Update description cell to truncate the text overflow and use tooltips

aabb130

Conversation

fabrice-akamai commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Uh oh!

Uh oh!

dwiley-akamai Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

fabrice-akamai Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abailly-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

fabrice-akamai Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

fabrice-akamai commented Apr 1, 2026

Uh oh!

linode-gh-bot commented Apr 1, 2026

Cloud Manager UI test results

🔺 3 failing tests on test run #7 ↗︎

Details

Troubleshooting

Uh oh!

tzmiivsk-akamai commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fabrice-akamai commented Mar 31, 2026 •

edited

Loading