fix(build): support legacy hardware via configurable base image#787
Open
xnaveenx wants to merge 1 commit intolitmuschaos:masterfrom
Open
fix(build): support legacy hardware via configurable base image#787xnaveenx wants to merge 1 commit intolitmuschaos:masterfrom
xnaveenx wants to merge 1 commit intolitmuschaos:masterfrom
Conversation
xnaveenx
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
xnaveenx
force-pushed
the
fix/786-legacy-hardware-support
branch
from
2fdfb4c to
63abda4
Compare
xnaveenx
force-pushed
the
fix/786-legacy-hardware-support
branch
from
63abda4 to
cd3a5f6
Compare
This introduces a BASE_IMAGE build argument to allow building the runner on legacy base images (e.g., UBI 8) for hardware lacking x86-64-v2 support. Default behavior (UBI 9) remains unchanged. Fixes litmuschaos#786 Signed-off-by: xnaveen <naveen010210@gmail.com>
xnaveenx
force-pushed
the
fix/786-legacy-hardware-support
branch
from
cd3a5f6 to
006078b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a
BASE_IMAGEbuild argument to the Dockerfile, allowing users to override the default UBI 9 base image with a legacy-compatible image (e.g., UBI 8 or Rocky Linux 8) at build time.x86-64-v2CPU instructions (AVX/SSE4.2). This causes aFatal glibc errorcrash on legacy hardware (e.g., Intel Pentium Gold, older Celerons) commonly used in home labs and edge devicesdocker build --build-arg BASE_IMAGE=rockylinux:8yum installcommands and dynamic EPEL detection ($(rpm -E %rhel)) to support both RHEL 8 and RHEL 9 environments.Which issue this PR fixes :
fixes #786
Special notes for your reviewer:
I have verified these changes locally on two environments:
docker build .-> SUCCESS. Verified thatstress-ngis correctly installed via the Oracle RPMs (matching original behavior).docker build --build-arg BASE_IMAGE=rockylinux:8 .-> SUCCESS. Verified on Intel Pentium Gold hardware where the standard image previously crashed. The legacy image runs experiments to completion.Checklist:
breaking-changestagrequires-upgradetag