feat: refactor duplicate error handling into utility function#285
Merged
SarthakJain26 merged 3 commits intolitmuschaos:masterfrom Oct 31, 2025
Merged
Conversation
ritoban23
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
Collaborator
|
@ritoban23 thanks for the PR, the helper function looks good, but you have only updated it in 2 instances. Please also reuse this function in all the places wherever applicable. We want to have a consistent error logging at all the places |
SarthakJain26
requested changes
Oct 24, 2025
Signed-off-by: ritoban23 <ankudutt101@gmail.com>
Signed-off-by: ritoban23 <ankudutt101@gmail.com>
ritoban23
force-pushed
the
refactor/error-handling-utility-function
branch
from
4fa2779 to
066056d
Compare
SarthakJain26
approved these changes
Oct 28, 2025
Collaborator
|
@ritoban23 PR looks good, but the fmt checks are failing, please fix them |
Signed-off-by: ritoban23 <ankudutt101@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Centralize Duplicate Error Handling Utility
This PR addresses #283 by extracting repeated CLI error formatting into a reusable utility function.
Changes
FormatErrorandPrintFormattedErrortopkg/utils/cliutil.gopkg/cmd/create/project.gopkg/cmd/save/experiment.goWhy?