Skip to content

Feat/updating documentation for Gnani #6004

Open
Gnani-AI-Mintlify wants to merge 2 commits into
livekit:mainfrom
Gnani-AI-Mintlify:feat/updating_documentation
Open

Feat/updating documentation for Gnani #6004
Gnani-AI-Mintlify wants to merge 2 commits into
livekit:mainfrom
Gnani-AI-Mintlify:feat/updating_documentation

Conversation

@Gnani-AI-Mintlify

Copy link
Copy Markdown
Contributor
  • Clarify STT usage as REST and ASR (real-time streaming).
  • Remove detailed STT/TTS access-method tables from the Gnani README.
  • Keep concise code examples for stt.recognize(), stt.stream(), and TTS synthesize/stream flows.
  • Removing the usage of organization_id and user_id.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment on lines 107 to 110
api_key: str | None = None,
sample_rate: int = SAMPLE_RATE_16K,
base_url: str = GNANI_STT_BASE_URL,
organization_id: str | None = None,
user_id: str | None = None,
http_session: None = None,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Breaking API change β€” removal of constructor parameters

This PR removes organization_id and user_id keyword arguments from STT.__init__(). Any existing user code that passes these parameters (e.g. STT(api_key=..., organization_id=..., user_id=...)) will get an unexpected keyword argument TypeError at runtime after upgrading. The README includes a migration note advising users to remove these parameters, which is appropriate for a breaking change. Consider whether this warrants a major version bump or a deprecation period with warnings before hard removal.

(Refers to lines 103-110)

Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant