Skip to content

(core): add function_tools_called event#6013

Open
tinalenguyen wants to merge 1 commit into
mainfrom
tina/add-tool-called-event
Open

(core): add function_tools_called event#6013
tinalenguyen wants to merge 1 commit into
mainfrom
tina/add-tool-called-event

Conversation

@tinalenguyen

Copy link
Copy Markdown
Member

No description provided.

@chenghao-mou chenghao-mou requested a review from a team June 8, 2026 18:24

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment on lines +780 to +784
if called_fnc_calls:
session.emit(
"function_tools_called",
FunctionToolsCalledEvent(function_calls=called_fnc_calls),
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 FunctionToolsCalledEvent is not forwarded via remote_session transport

The remote_session.py registers handlers for function_tools_executed at livekit-agents/livekit/agents/voice/remote_session.py:374 to forward it over the protobuf transport, but does not register a handler for the new function_tools_called event. This appears intentional since there's no corresponding protobuf message type (AgentSessionEvent.FunctionToolsCalled) defined. If remote consumers (e.g., frontend clients) need to know about tool calls before execution completes, a protobuf message and handler would need to be added in a follow-up.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant