(core): add function_tools_called event#6013
Open
tinalenguyen wants to merge 1 commit into
Open
Conversation
Comment on lines
+780
to
+784
| if called_fnc_calls: | ||
| session.emit( | ||
| "function_tools_called", | ||
| FunctionToolsCalledEvent(function_calls=called_fnc_calls), | ||
| ) |
Contributor
There was a problem hiding this comment.
🚩 FunctionToolsCalledEvent is not forwarded via remote_session transport
The remote_session.py registers handlers for function_tools_executed at livekit-agents/livekit/agents/voice/remote_session.py:374 to forward it over the protobuf transport, but does not register a handler for the new function_tools_called event. This appears intentional since there's no corresponding protobuf message type (AgentSessionEvent.FunctionToolsCalled) defined. If remote consumers (e.g., frontend clients) need to know about tool calls before execution completes, a protobuf message and handler would need to be added in a follow-up.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.