Add missing connection quality field#696
Open
1egoman wants to merge 2 commits into
Open
Conversation
1egoman
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
lukasIO
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most other client sdks (checked web, swift, and android) support a
participant.connectionQualitytype field in addition to a "participant connection quality changed" event. However, the python sdk seems to be missing it, and only exposes this over an event. Fix this so that the sdks are more consistent with each other.Note that I have opted to introduce a shadowed
ConnectionQualitycustom enum rather than return the protobuf version directly here (like how it used to work). This should be fully backwards compatible and means that the newparticipant.connection_qualityfield can beQUALITY_UNKNOWNuntil the first connection quality event is received, matching behavior in other sdks.