Fix occasional green artifact when using NVENC and uvc camera#1135
Merged
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
cloudwebrtc
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NVIDIA hardware-encoded
local_videopublisher corruption that showed up as green stripes or intermittent green artifacts on subscribers.What changed
DataY()andStrideY().Why
WebRTC/NVENC can consume captured frames asynchronously, so reusing the same backing buffer could overwrite frames still in flight. Separately, padded I420 buffers, such as frames prepared for local preview/display, can have UV strides that do not derive from the Y stride. The old NVENC upload path could therefore read the wrong chroma data.