SP-2566: a new NB tutorial on extendedness parameters#138
SP-2566: a new NB tutorial on extendedness parameters#138
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
I think CModel should be cModel? Please check.
Also in the same bullet point, PSF is already defined and the acronym can be used at the end.
Reply via ReviewNB
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
Again maybe CModel -> cModel in the 2nd bullet point, and also in the ratio in the 2nd to last sentence. Maybe cModel and psfFlux should be in quotes?
Might be useful to explicitly spell out the parameter name i.e. <f>_free_cModelFlux and <f>_free_psfFlux in the bulletpoints (here at first definition).
I also wonder if it is worth a sentence to explain what the significance of the number 0.985 is and why that is the threshold for choosing which of the two flags the extendedness parameter gets.
Reply via ReviewNB
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
Might be good to briefly say what free means in this case and why it is used instead of the non free versions of the flux measurements (because i think in the photometry notebook we don't use the free version of cModel and instead recommend the fixed one)
Reply via ReviewNB
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,840 @@ | |||
| { | |||
There was a problem hiding this comment.
Again maybe CModel should be cModel. Also suggest clarifying what "not populated" means (is it NaN? Replaced by -99 or -1 or just blank? Could help people include a way to exclude them)
Reply via ReviewNB
|
I reviewed the notebook and left some comments in reviewNB. Please let me know if you have questions or what you think. Otherwise I think it is ready to post! |
christinawilliams
left a comment
christinawilliams
left a comment
There was a problem hiding this comment.
Great notebook Yumi! I left a number of comments but they are minor, I hit approve so that once the feedback is included you can merge.
2 participants
This new NB tutorial demonstrates the DP1 flux-based and size-based extendedness parameters.