Skip to content

fix: remove unused imports and variables (part 1 — packages & non-web-core) #8751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 5 commits into from
Mar 24, 2026
Merged

fix: remove unused imports and variables (part 1 — packages & non-web-core) #8751

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
566a8b5
fix: remove unused imports and variables (part 1)
darkingtail Mar 12, 2026
000ce48
fix: resolve CI check failures
darkingtail Mar 12, 2026
3e0edea
fix: resolve check:types failures
darkingtail Mar 12, 2026
d63b9c2
fix: resolve check:types and check:format failures
darkingtail Mar 12, 2026
f7d909b
fix: format propel button helper with oxfmt
darkingtail Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/admin/app/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export function HydrateFallback() {
);
}

export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) {
export function ErrorBoundary({ _error }: Route.ErrorBoundaryProps) {
return (
<div>
<p>Something went wrong.</p>
Expand Down
1 change: 0 additions & 1 deletion apps/live/src/lib/pdf/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
CODE_COLORS,
LINK_COLORS,
MENTION_COLORS,
NEUTRAL_COLORS,
TEXT_COLORS,
} from "./colors";

Expand Down
2 changes: 1 addition & 1 deletion apps/space/app/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ export function HydrateFallback() {
);
}

export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) {
export function ErrorBoundary({ _error }: Route.ErrorBoundaryProps) {
return <ErrorPage />;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}
2 changes: 1 addition & 1 deletion apps/space/hooks/use-editor-flagging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export type TEditorFlaggingHookReturnType = {
/**
* @description extensions disabled in various editors
*/
export const useEditorFlagging = (anchor: string): TEditorFlaggingHookReturnType => ({
export const useEditorFlagging = (_anchor: string): TEditorFlaggingHookReturnType => ({
document: {
disabled: [],
flagged: [],
Expand Down
1 change: 0 additions & 1 deletion apps/web/app/(all)/[workspaceSlug]/(projects)/_sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { useState } from "react";
import { observer } from "mobx-react";
// plane imports
Expand Down
2 changes: 0 additions & 2 deletions apps/web/app/(all)/[workspaceSlug]/(projects)/profile/[userId]/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

// ui
import type { FC } from "react";
import { observer } from "mobx-react";
import { useParams, useRouter } from "next/navigation";
import { PanelRight } from "lucide-react";
Expand All @@ -14,7 +13,6 @@ import { useTranslation } from "@plane/i18n";
import { YourWorkIcon, ChevronDownIcon } from "@plane/propel/icons";
import type { IUserProfileProjectSegregation } from "@plane/types";
import { Breadcrumbs, Header, CustomMenu } from "@plane/ui";
import { cn } from "@plane/utils";
// components
import { BreadcrumbLink } from "@/components/common/breadcrumb-link";
import { ProfileIssuesFilter } from "@/components/profile/profile-issues-filter";
Expand Down
1 change: 0 additions & 1 deletion apps/web/app/(all)/[workspaceSlug]/(projects)/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { isEmpty } from "lodash-es";
import { observer } from "mobx-react";
// plane helpers
Expand Down
1 change: 0 additions & 1 deletion apps/web/app/(all)/invitations/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ function UserInvitationsPage() {
.then(() => {
mutate(USER_WORKSPACES_LIST);
const firstInviteId = invitationsRespond[0];
const invitation = invitations?.find((i) => i.id === firstInviteId);
const redirectWorkspace = invitations?.find((i) => i.id === firstInviteId)?.workspace;
updateUserProfile({ last_workspace_id: redirectWorkspace?.id })
.then(() => {
Expand Down
2 changes: 1 addition & 1 deletion apps/web/ce/components/analytics/use-analytics-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { useMemo } from "react";
import { useTranslation } from "@plane/i18n";
import { getAnalyticsTabs } from "./tabs";

export const useAnalyticsTabs = (workspaceSlug: string) => {
export const useAnalyticsTabs = (_workspaceSlug: string) => {
const { t } = useTranslation();

const analyticsTabs = useMemo(() => getAnalyticsTabs(t), [t]);
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/automations/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";

export type TCustomAutomationsRootProps = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/command-palette/modals/work-item-level.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { observer } from "mobx-react";
import { useParams } from "next/navigation";
// plane imports
Expand Down
2 changes: 1 addition & 1 deletion apps/web/ce/components/common/subscription/subscription-pill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ type TProps = {
workspace?: IWorkspace;
};

export function SubscriptionPill(props: TProps) {
export function SubscriptionPill(_props: TProps) {
return <></>;
}
2 changes: 1 addition & 1 deletion apps/web/ce/components/cycles/active-cycle/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type ActiveCyclesComponentProps = {
const ActiveCyclesComponent = observer(function ActiveCyclesComponent({
cycleId,
activeCycle,
activeCycleResolvedPath,
_activeCycleResolvedPath,
workspaceSlug,
projectId,
handleFiltersUpdate,
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/cycles/additional-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { observer } from "mobx-react";
type Props = {
cycleId: string;
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/cycles/analytics-sidebar/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
// components
import { SidebarChart } from "./base";
Expand Down
4 changes: 1 addition & 3 deletions apps/web/ce/components/de-dupe/de-dupe-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
// local components

Expand All @@ -15,7 +14,6 @@ type TDeDupeButtonRoot = {
label: string;
};

export function DeDupeButtonRoot(props: TDeDupeButtonRoot) {
const { workspaceSlug, isDuplicateModalOpen, label, handleOnClick } = props;
export function DeDupeButtonRoot(_props: TDeDupeButtonRoot) {
return <></>;
Comment on lines +17 to 18
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE='apps/web/ce/components/de-dupe/de-dupe-button.tsx'

echo "Relevant snippet:"
sed -n '7,19p' "$FILE"

echo
echo "React namespace usages in this file (expected: no matches):"
rg -n '\bReact\.' "$FILE" || true

Repository: makeplane/plane

Length of output: 400

Remove the unused React default import.

The component no longer uses the React namespace, and this file uses the modern JSX transform. The unused import on line 7 should be removed.

♻️ Proposed fix 
-import React from "react";
 // local components
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/ce/components/de-dupe/de-dupe-button.tsx` around lines 17 - 18,
Remove the unused default React import from this module: the component
DeDupeButtonRoot no longer references the React namespace (modern JSX transform
is used), so delete the React import statement and keep any existing named
imports if present to eliminate the unused import warning and clean up the file.

}
4 changes: 1 addition & 3 deletions apps/web/ce/components/de-dupe/duplicate-modal/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
// types
import type { TDeDupeIssue } from "@plane/types";

Expand All @@ -14,7 +13,6 @@ type TDuplicateModalRootProps = {
handleDuplicateIssueModal: (value: boolean) => void;
};

export function DuplicateModalRoot(props: TDuplicateModalRootProps) {
const { workspaceSlug, issues, handleDuplicateIssueModal } = props;
export function DuplicateModalRoot(_props: TDuplicateModalRootProps) {
return <></>;
}
1 change: 0 additions & 1 deletion apps/web/ce/components/de-dupe/duplicate-popover/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
import { observer } from "mobx-react";
// types
Expand Down
5 changes: 1 addition & 4 deletions apps/web/ce/components/de-dupe/issue-block/button-label.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";

type TDeDupeIssueButtonLabelProps = {
isOpen: boolean;
buttonLabel: string;
};

export function DeDupeIssueButtonLabel(props: TDeDupeIssueButtonLabelProps) {
const { isOpen, buttonLabel } = props;
export function DeDupeIssueButtonLabel(_props: TDeDupeIssueButtonLabelProps) {
return <></>;
}
3 changes: 1 addition & 2 deletions apps/web/ce/components/epics/epic-modal/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
import type { TIssue } from "@plane/types";

Expand All @@ -22,6 +21,6 @@ export interface EpicModalProps {
isProjectSelectionDisabled?: boolean;
}

export function CreateUpdateEpicModal(props: EpicModalProps) {
export function CreateUpdateEpicModal(_props: EpicModalProps) {
return <></>;
}
2 changes: 0 additions & 2 deletions apps/web/ce/components/estimates/inputs/time-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";

export type TEstimateTimeInputProps = {
value?: number;
handleEstimateInputValue: (value: string) => void;
Expand Down
2 changes: 0 additions & 2 deletions apps/web/ce/components/estimates/points/delete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";

import type { TEstimatePointsObject, TEstimateSystemKeys, TEstimateTypeErrorObject } from "@plane/types";

export type TEstimatePointDelete = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/estimates/update/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { observer } from "mobx-react";

type TUpdateEstimateModal = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/gantt-chart/blocks/blocks-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
//
import type { IBlockUpdateDependencyData } from "@plane/types";
import { GanttChartBlock } from "@/components/gantt-chart/blocks/block";
Expand Down
2 changes: 1 addition & 1 deletion apps/web/ce/components/gantt-chart/dependency/blockDraggables/left-draggable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ type LeftDependencyDraggableProps = {
ganttContainerRef: RefObject<HTMLDivElement>;
};

export function LeftDependencyDraggable(props: LeftDependencyDraggableProps) {
export function LeftDependencyDraggable(_props: LeftDependencyDraggableProps) {
return <></>;
}
2 changes: 1 addition & 1 deletion apps/web/ce/components/gantt-chart/dependency/blockDraggables/right-draggable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ type RightDependencyDraggableProps = {
block: IGanttBlock;
ganttContainerRef: RefObject<HTMLDivElement>;
};
export function RightDependencyDraggable(props: RightDependencyDraggableProps) {
export function RightDependencyDraggable(_props: RightDependencyDraggableProps) {
return <></>;
}
5 changes: 1 addition & 4 deletions apps/web/ce/components/gantt-chart/dependency/dependency-paths.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";

type Props = {
isEpic?: boolean;
};
export function TimelineDependencyPaths(props: Props) {
const { isEpic = false } = props;
export function TimelineDependencyPaths(_props: Props) {
return <></>;
}
2 changes: 1 addition & 1 deletion apps/web/ce/components/inbox/source-pill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ export type TInboxSourcePill = {
source: EInboxIssueSource;
};

export function InboxSourcePill(props: TInboxSourcePill) {
export function InboxSourcePill(_props: TInboxSourcePill) {
return <></>;
}
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/filters/issue-types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type React from "react";
import { observer } from "mobx-react";

type Props = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/filters/team-project.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type React from "react";
import { observer } from "mobx-react";

type Props = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-detail-widgets/action-buttons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
// plane types
import type { TIssueServiceType, TWorkItemWidgets } from "@plane/types";

Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-detail-widgets/collapsibles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
// plane types
import type { TIssueServiceType, TWorkItemWidgets } from "@plane/types";

Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-detail-widgets/modals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
// plane types
import type { TIssueServiceType, TWorkItemWidgets } from "@plane/types";

Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-details/additional-activity-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { observer } from "mobx-react";

export type TAdditionalActivityRoot = {
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-details/additional-properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
// plane imports

Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-details/issue-creator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import Link from "next/link";
// hooks
import { useIssueDetail } from "@/hooks/store/use-issue-detail";
Expand Down
2 changes: 0 additions & 2 deletions apps/web/ce/components/issues/issue-details/issue-properties-activity/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";

type TIssueAdditionalPropertiesActivity = {
activityId: string;
ends: "top" | "bottom" | undefined;
Expand Down
1 change: 0 additions & 1 deletion apps/web/ce/components/issues/issue-details/issue-type-activity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import { observer } from "mobx-react";

export type TIssueTypeActivity = { activityId: string; showIssue?: boolean; ends: "top" | "bottom" | undefined };
Expand Down
4 changes: 2 additions & 2 deletions apps/web/ce/components/issues/issue-details/parent-select-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const IssueParentSelectRoot = observer(function IssueParentSelectRoot(pro
await issueOperations.fetch(workspaceSlug, projectId, issueId, false);
if (_issueId) await fetchSubIssues(workspaceSlug, projectId, _issueId);
toggleParentIssueModal(null);
} catch (error) {
} catch (_error) {
console.error("something went wrong while fetching the issue");
}
Comment on lines +50 to 52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Keep the caught error available for logging/reporting.

These renames make both failure paths intentionally discard the exception object, so parent-link failures now only surface a generic message/toast with no stack or error details. Keep the binding typed as unknown and include it in the log/report before showing generic UI feedback.

🛠️ Suggested cleanup 
-    } catch (_error) {
-      console.error("something went wrong while fetching the issue");
+    } catch (error: unknown) {
+      console.error("something went wrong while updating the parent issue", error);
     }
@@
-    } catch (_error) {
+    } catch (error: unknown) {
+      console.error("something went wrong while removing the sub-issue", error);
       setToast({
         type: TOAST_TYPE.ERROR,
         title: t("common.error.label"),
         message: t("common.something_went_wrong"),
       });
     }

As per coding guidelines, "Use try-catch with proper error types and log errors appropriately for error handling".

Also applies to: 66-72

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/ce/components/issues/issue-details/parent-select-root.tsx` around
lines 50 - 52, The catch blocks in parent-select-root.tsx currently discard the
caught exception by using _error; change the catch bindings to a typed variable
(e.g., error: unknown) and include that variable in your logging/reporting
before showing the generic UI toast. Specifically, replace "catch (_error)" with
"catch (error: unknown)" and update the console.error call to include the error
(and call any existing error-reporting helper like reportError or
processLogger.error with the error) so the stack/message is preserved; apply the
same change to the other catch block handling parent-link failures.

};
Expand All @@ -63,7 +63,7 @@ export const IssueParentSelectRoot = observer(function IssueParentSelectRoot(pro
await removeSubIssue(workspaceSlug, projectId, parentIssueId, issueId);
await fetchSubIssues(workspaceSlug, projectId, parentIssueId);
setSubIssueHelpers(parentIssueId, "issue_loader", issueId);
} catch (error) {
} catch (_error) {
setToast({
type: TOAST_TYPE.ERROR,
title: t("common.error.label"),
Expand Down
3 changes: 1 addition & 2 deletions apps/web/ce/components/issues/issue-layouts/additional-properties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* See the LICENSE file for details.
*/

import type { FC } from "react";
import React from "react";
import type { IIssueDisplayProperties, TIssue } from "@plane/types";

Expand All @@ -13,6 +12,6 @@ export type TWorkItemLayoutAdditionalProperties = {
issue: TIssue;
};

export function WorkItemLayoutAdditionalProperties(props: TWorkItemLayoutAdditionalProperties) {
export function WorkItemLayoutAdditionalProperties(_props: TWorkItemLayoutAdditionalProperties) {
return <></>;
}
Loading
Loading