Work around Safari bug with negative margins used in bussproofs. (mathjax/MathJax#3547)#1457
Open
dpvc wants to merge 2 commits intofix/margin-spacingfrom
Open
Work around Safari bug with negative margins used in bussproofs. (mathjax/MathJax#3547)#1457dpvc wants to merge 2 commits intofix/margin-spacingfrom
dpvc wants to merge 2 commits intofix/margin-spacingfrom
Conversation
zorkow
approved these changes
Apr 9, 2026
Member
zorkow
left a comment
There was a problem hiding this comment.
Nice. That makes the structures a lot cleaner.
Member
Author
|
I've made another commit to this branch to remove a check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works around a bug in Safari that causes the negative spacing at the right-hand side of bussproof layouts to be ignored when computing the widths of the parent element. This does away with the
mspaceelements at the left and right of the layouts and usesmargin-leftandmargin-rightCSS attributes instead. I have resisted using CSS in this way in the past, trying to keep everything in MathML directly, but could not find another solution that worked in all browsers.Resolves issue mathjax/MathJax#3547.