fix(sensecap_solar): correct TX LED after remap & power-button pin changes#2157
Open
Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(sensecap_solar): correct TX LED after remap & power-button pin changes#2157Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Confituurke wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Align TX activity LED with LED_BLUE / variant.h after LED definition and power-button pin mapping changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the SenseCap Solar build flag
P_LORA_TX_LEDfrom11to12so LoRa TX activity is driven on the blue LED again, consistent withvariants/sensecap_solar/variant.h(LED_BLUE / PIN_LED on pin 12).SenseCap Solar LED GPIO definitions were corrected in #1689 . A later power-button–related pin mapping change e323755 , #1873 updated board wiring, but
P_LORA_TX_LEDchanged to11, which maps toLED_WHITEin the current headers and caused drift between the forks. That made the white LED blink on TX, which looks like a white/blue swap even though the underlying problem was the TX LED build flag not matching the updated LED pin macros.@ripplebiz & @liamcottle FYI and approval; so these don't get changed/overwritten in another future PR.
@Specter242 FYI; since you initiated PR #1873
Thank you