Skip to content

Fix Tracking & 404 Banner#1153

Merged
gantoreno merged 5 commits into
masterfrom
fix/tracking-and-banner-on-404
May 28, 2026
Merged

Fix Tracking & 404 Banner#1153
gantoreno merged 5 commits into
masterfrom
fix/tracking-and-banner-on-404

Conversation

@gantoreno
Copy link
Copy Markdown
Contributor

@gantoreno gantoreno commented May 27, 2026

Fixes GRO-460, GRO-472

  • Uses the shared chrome as the nav elements in the 404 page instead of the legacy ones.
  • Sets build env to production for amplify deployments to enable anonymous tracking
  • Adds the shared-chrome to the committed file list so that it stays up-to-date with master.

@gantoreno gantoreno requested a review from a team May 27, 2026 20:31
@gantoreno gantoreno self-assigned this May 27, 2026
Copy link
Copy Markdown
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually pulling the chrome in a PR, can this just be part of the build process for this repo? isn't that the whole point of shared chrome? so we don't have to sync code? it should just get pulled in from the single source of truth at build time.

@gantoreno
Copy link
Copy Markdown
Contributor Author

gantoreno commented May 28, 2026

@iethree it is a part of the build process (see script/build). The pulling of the latest chrome was something I did very early and I thought that it would eventually be overridden by whatever the repo auto-pulled from CI eventually. It was also based on the wrong assumption that the issue was the script (turns out it was the second commit about using the actual chrome that fixed it).

Strangely enough, now that you pointed it out (and I see that the chrome is still part of the diff and not up-to-date or behind), I realized that the issue isn't pulling it on build, but that it's not being committed, so it just stays hanging as a dirty file in CI that never gets updated.

Just pushed fix: also commit shared chrome which adds _data/shared-chrome.json to the committed files - I didn't know that _data was not part of the auto-updated/committed files. That should fix it.

I also updated the PR description.

@gantoreno gantoreno requested a review from iethree May 28, 2026 16:45
@gantoreno gantoreno merged commit 7b04032 into master May 28, 2026
1 check passed
@gantoreno gantoreno deleted the fix/tracking-and-banner-on-404 branch May 28, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants