Skip to content

Fix retry button not working but show "Render error"#5838

Open
compulim wants to merge 5 commits into
microsoft:mainfrom
compulim:fix-send-failed-retry
Open

Fix retry button not working but show "Render error"#5838
compulim wants to merge 5 commits into
microsoft:mainfrom
compulim:fix-send-failed-retry

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Jun 5, 2026

Changelog Entry

Fixed

  • Fixed the "Retry" button to resend the message after it fails to send, instead of showing "Render error", by @compulim in PR #5838

Description

The "Send failed. Retry" button failed to resend the message because local ID was not remove on resend.

We should revisit the retry logic in the future. It should not show 2 messages.

Design

Specific Changes

  • Remove "local ID" on post activity
    • Today, we also regenerated the "clientActivityId"
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review June 5, 2026 08:49
@compulim compulim requested a review from a-b-r-o-w-n as a code owner June 5, 2026 08:49
Copilot AI review requested due to automatic review settings June 5, 2026 08:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “Send failed. Retry” flow by ensuring internal channelData identifiers don’t prevent resending an existing (failed) outgoing activity, and adds a regression test plus a changelog entry.

Changes:

  • Strip webchat:internal:local-id from activity.channelData when constructing the outgoing activity for postActivity.
  • Add an HTML2 test covering the “send failed → retry → resend” scenario.
  • Add an Unreleased changelog entry documenting the fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/core/src/sagas/postActivitySaga.ts Removes internal local ID from outgoing channelData before posting to Direct Line to unblock retry behavior.
CHANGELOG.md Adds an Unreleased “Fixed” entry describing the retry/resend bugfix.
tests/html2/activityStatus/sendFailedRetry.html New HTML2 regression test for retrying a send-failed outgoing message (with snapshots).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/src/sagas/postActivitySaga.ts
Comment thread CHANGELOG.md Outdated
Comment thread __tests__/html2/activityStatus/sendFailedRetry.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants