Fix retry button not working but show "Render error"#5838
Open
compulim wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the “Send failed. Retry” flow by ensuring internal channelData identifiers don’t prevent resending an existing (failed) outgoing activity, and adds a regression test plus a changelog entry.
Changes:
- Strip
webchat:internal:local-idfromactivity.channelDatawhen constructing the outgoing activity forpostActivity. - Add an HTML2 test covering the “send failed → retry → resend” scenario.
- Add an Unreleased changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/sagas/postActivitySaga.ts | Removes internal local ID from outgoing channelData before posting to Direct Line to unblock retry behavior. |
| CHANGELOG.md | Adds an Unreleased “Fixed” entry describing the retry/resend bugfix. |
| tests/html2/activityStatus/sendFailedRetry.html | New HTML2 regression test for retrying a send-failed outgoing message (with snapshots). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
The "Send failed. Retry" button failed to resend the message because local ID was not remove on resend.
We should revisit the retry logic in the future. It should not show 2 messages.
Design
Specific Changes
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)