-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Python: Skip get_final_response in OTel _finalize_stream when stream errored #5232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
moonbox3
merged 7 commits into
microsoft:main
from
droideronline:dinesh/fix-otel-finalize-stream-result-hooks-on-error
Apr 14, 2026
+19
−2
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b345761
Python: Skip get_final_response in OTel _finalize_stream when stream …
droideronline 074d413
Python: Expose consumed/stream_error on ResponseStream and capture er…
droideronline e59e880
Python: Address Copilot review feedback on stream error handling
droideronline 7de07a0
Merge branch 'main' into dinesh/fix-otel-finalize-stream-result-hooks…
droideronline a450307
Python: Remove consumed/stream_error properties, use private attrs di…
droideronline 3a6ca9d
Merge branch 'main' into dinesh/fix-otel-finalize-stream-result-hooks…
droideronline efbb61d
Python: Fix Pyright reportPrivateUsage via inline ignore comments
droideronline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.